Runtime benchmarks#1126
Merged
Merged
Conversation
2c73c97 to
5bdeb3a
Compare
Member
|
Could you try uncommenting the benchmarks in: https://github.com/TypeScriptToLua/TypeScriptToLua/blob/master/.github/workflows/ci.yml? They are meant to be uncommented but I forgot it, and it would also be good to see what happens with your new benchmarks. |
there's already benchmark/src/json.lua
e524630 to
a048426
Compare
Contributor
Author
|
Are the benchmark output (markdown) supposed to be in a particular format for benchviz to work? In the CI, it displays a blank page. EDIT: it seems to be an issue with the browser, not having access to |
Perryvw
reviewed
Sep 8, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
* Basic runtime benchmarks * Add basic doc for runtime benchmarks * Fix runtime benchmark text formatting * Add /benchmark/dist to .prettierignore * Sort benchmarks by name * Remove benchmark/dist/json.lua from gitignore there's already benchmark/src/json.lua * Enable benchmark in ci * Refactor comparison Markdown formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic runtime benchmarks, modeled off of existing memory benchmarks.
At least can be used for local benchmarks; Still need to test with github workflows.