style: use const when possible#230
Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom Feb 14, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 97 97
Lines 1797 1797
Branches 347 347
=======================================
Hits 1731 1731
Misses 66 66 ☔ View full report in Codecov by Sentry. |
appgurueu
approved these changes
Feb 11, 2024
raklaptudirm
approved these changes
Feb 14, 2024
This was referenced Jun 3, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested here, I stared exploring linting/static analysis tools available for TypeScript. The TypeScipt eslint seems to be reasonable. These changes are the result of running
npx eslint . --fix, and from what I see it has changedlettoconst, which is a tiny step in a good direction.