i18n: add Korean (ko) translation#463
Conversation
Adds a complete Korean locale (src/i18n/locales/ko.json) matching the exact key structure of en.json (1574/1574 leaf keys, all interpolation placeholders preserved), and registers it in the SUPPORTED_LANGUAGES list in src/i18n/config.ts following the existing pattern.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (13 files)
Previous Review Summary (commit 3fefb05)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3fefb05)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by kimi-k2.6 · Input: 159.9K · Output: 8.6K · Cached: 516.1K |
|
Hi @moduvoice, thank you so much for this, adding a whole new language is a lot of careful work, and I really appreciate it. I have to be honest: I don't speak Korean, so I'm not able to judge the translations myself. But I trust you on this one :) and I hope you'll stick around and keep refining it over time as the app grows and new strings come in. One small thing: I went ahead and pushed a commit to your branch adding a If you feel like it, come say hi on our Discord, it'd be great to talk directly: https://discord.com/invite/K2hmhfHRSt Thanks again! |
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
src/i18n/locales/ko.jsonwith all 1574 keys translated (full parity withen.json).src/i18n/config.tsto importko.jsonand register{ id: "ko", label: "한국어", translation: ko }inSUPPORTED_LANGUAGES, following the exact same pattern as the other 7 locales (en/it/es/zh/fr/de/ja/ru).Testing
en.json: 0 missing keys, 0 extra keys, 0 interpolation-placeholder ({{var}}) mismatches.taskManager.killModal.descriptionBefore/descriptionAfter(rendered around the interpolated{pluginName}inTaskManagerPage.tsx) avoid attaching a Korean particle (josa) directly to the plugin name, since the correct particle depends on the name's final syllable and isn't knowable at translation time.이(가),을(를)) are used wherever a josa would otherwise attach to an interpolated variable of unknown final syllable._one/_otherplural-suffixed keys are intentionally identical, matching the existing convention inja.json(Korean has no grammatical plural distinction).