Skip to content

Add Support for xunit.v3#339

Merged
alexanderlinne merged 12 commits intoTNG:mainfrom
ljb:xunit-v3
Feb 28, 2025
Merged

Add Support for xunit.v3#339
alexanderlinne merged 12 commits intoTNG:mainfrom
ljb:xunit-v3

Conversation

@ljb
Copy link
Copy Markdown
Contributor

@ljb ljb commented Feb 11, 2025

Add support for xunit.v3

Fixes: #338

@ljb ljb mentioned this pull request Feb 11, 2025
Add support for xunit.v3

Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
@alexanderlinne alexanderlinne changed the title Issue: 338 Add Support for xunit.v3 Feb 14, 2025
Copy link
Copy Markdown
Collaborator

@alexanderlinne alexanderlinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Could you add a test project similar to the ones for MSTestV2 und NUnit?

Comment thread ArchUnitNET.xUnitV3/ArchUnitNET.xUnitV3.csproj Outdated
Comment thread ArchUnitNET.xUnitV3/ArchUnitNET.xUnitV3.csproj Outdated
ljb and others added 2 commits February 14, 2025 13:07
Co-authored-by: Alexander Linne <doubts.0.terse@icloud.com>
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
ljb and others added 3 commits February 14, 2025 13:21
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.65%. Comparing base (5506ac5) to head (0f45065).
⚠️ Report is 224 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   65.65%   65.65%           
=======================================
  Files         255      255           
  Lines       23032    23032           
  Branches     1962     1962           
=======================================
  Hits        15121    15121           
  Misses       7366     7366           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderlinne
Copy link
Copy Markdown
Collaborator

@ljb Could you reformat the code once? Also we've removed the License Headers from the source files and the explicit authors from .csproj since you've opened this pull request. Would be great if you could do the same here.

ljb added 2 commits February 28, 2025 09:33
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
@ljb
Copy link
Copy Markdown
Contributor Author

ljb commented Feb 28, 2025

@alexanderlinne: I have now removed the explicit authors and license code.

I also reformated the code with Rider. That didn't change much code though. Since there is no .editorconfig Rider uses an auto-detect for code style rules.

@alexanderlinne
Copy link
Copy Markdown
Collaborator

You should be able to correctly reformet the code by running:

dotnet tool restore
dotnet csharpier .

Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>
@ljb
Copy link
Copy Markdown
Contributor Author

ljb commented Feb 28, 2025

@alexanderlinne: I have now run dotnet csharpier.

Great stuff! 👍

Copy link
Copy Markdown
Collaborator

@alexanderlinne alexanderlinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes :) Just have to get the tests running and then we are good to go

Comment thread ArchUnitNET.xUnitTests/ArchUnitNET.xUnitTests.csproj Outdated
Comment thread ArchUnitNET.xUnitV3Tests/ArchUnitNET.xUnitV3Tests.csproj Outdated
ljb and others added 2 commits February 28, 2025 10:15
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>

Co-authored-by: Alexander Linne <doubts.0.terse@icloud.com>
Signed-off-by: Jonas Bengtsson <jonas@bengtsson.cc>

Co-authored-by: Alexander Linne <doubts.0.terse@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for xunit.v3

3 participants