[pull] master from google:master by pull[bot] · Pull Request #5 · Stars1233/python-fire

pull · 2025-05-22T06:17:02Z

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update CI linting dependency and runner configuration, and correct class attribute lookup in autocompletion logic

Bug Fixes:

Fix class attribute resolution in MemberVisible by passing the component to GetClassAttrsDict

Build:

Bump pylint version to <3.3.7 in CI requirements

CI:

Update GitHub Actions matrix to use Ubuntu 22.04 instead of 20.04 for Python 3.7

* inspectutils.GetClassAttrsDict on component, not None * Remove ubuntu-20.04 in favor of ubuntu-22.04 for Python 3.7

…591) Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@pylint-version-0.18.1...v3.3.6) --- updated-dependencies: - dependency-name: pylint dependency-version: 3.3.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

sourcery-ai · 2025-05-22T06:17:07Z

Reviewer's Guide

This PR updates CI tooling versions and workflows to newer releases and fixes an attribute inspection bug in the MemberVisible function by correcting the argument passed to GetClassAttrsDict.

Sequence Diagram: Argument Correction in MemberVisible's Call to GetClassAttrsDict

sequenceDiagram
    participant Caller as "Caller"
    participant MV as "MemberVisible(component, ..., class_attrs=None, ...)"
    participant IGAD as "inspectutils.GetClassAttrsDict"

    Caller->>MV: Invoke MemberVisible
    MV->>MV: Check: component is class AND class_attrs is None
    alt Previous Behavior (Incorrect Argument)
        MV->>IGAD: GetClassAttrsDict(None) 
    else Current Behavior (Corrected Argument)
        MV->>IGAD: GetClassAttrsDict(component)
    end
    IGAD-->>MV: Return class attributes dict
    MV-->>Caller: Return visibility result

File-Level Changes

Change	Details	Files
Bump pylint dependency version in CI scripts	Updated upper bound of pylint from <3.3.5 to <3.3.7	`.github/scripts/requirements.txt`
Upgrade CI test matrix environment	Replaced ubuntu-20.04 runner with ubuntu-22.04 for Python 3.7	`.github/workflows/build.yml`
Fix class attribute resolution in MemberVisible	Pass component instead of class_attrs to GetClassAttrsDict to correctly retrieve class attributes	`fire/completion.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gitstream-cm · 2025-05-22T06:17:07Z

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 3920/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

coderabbitai · 2025-05-22T06:17:09Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dbieber and others added 2 commits May 21, 2025 12:23

Call inspectutils.GetClassAttrsDict on component, not None (#606)

fb01c7c

* inspectutils.GetClassAttrsDict on component, not None * Remove ubuntu-20.04 in favor of ubuntu-22.04 for Python 3.7

pull bot added the ⤵️ pull label May 22, 2025

pull bot merged commit 51974c6 into Stars1233:master May 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from google:master#5

[pull] master from google:master#5
pull[bot] merged 2 commits intoStars1233:masterfrom
google:master

pull bot commented May 22, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented May 22, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gitstream-cm bot commented May 22, 2025

Uh oh!

coderabbitai bot commented May 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pull bot commented May 22, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence Diagram: Argument Correction in MemberVisible's Call to GetClassAttrsDict

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gitstream-cm bot commented May 22, 2025

Uh oh!

coderabbitai bot commented May 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pull bot commented May 22, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented May 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)