JS-1394

Ruling Report

Code no longer flagged (2 issues)

S6767

ant-design/components/anchor/Anchor.tsx:70

    68 | 
    69 | export interface AnchorState {
>   70 |   activeLink: null | string;
    71 | }
    72 | 

S2094

custom-jsts/S3854.js:350

   348 | 
   349 | 
>  350 | class Foo {
   351 |     constructor(name, options = {}) {
   352 |         this.name = name;

New issues flagged (4 issues)

S5845

rxjs/spec/Subject-spec.ts:268

   266 |         function (x) { results3.push(x); },
   267 |         function (err) {
>  268 |           expect(false).to.equal('should not throw error: ' + err.toString());
   269 |         }
   270 |       );

rxjs/spec/observables/IteratorObservable-spec.ts:152

   150 |     IteratorObservable.create('foo')
   151 |       .subscribe(
>  152 |         (x: number) => { expect(x).to.equal(expected.shift()); },
   153 |         (x) => {
   154 |           done(new Error('should not be called'));

vitest/test/coverage-test/fixtures/test/mocking-in-js-file.test.js:9

     7 | 
     8 | test('mocking in Javascript test should not break sourcemaps', () => {
>    9 |   expect(sum(1, 2)).toBe('mocked')
    10 | })
    11 | 

vitest/test/browser/fixtures/mocking/mocked-nested.test.ts:14

    12 | test('adds', () => {
    13 |   child.mockReturnValue(42)
>   14 |   expect(parent()).toBe(42)
    15 | })
    16 | 

Summary

What changed: This PR fixes false-positive S6767 reports on React class non-props generics (state/snapshot) by introducing per-component suppression logic and a new TypeScript-based check.

When React classes declare all three type parameters (React.Component<Props, State, Snapshot>), the upstream eslint-plugin-react can misreport State members as unused props. This PR:

• New file react-non-props-usage.ts: Detects when a type is used as a React class's 2nd+ generic argument (non-props), not props
• Refactored decorator.ts: Changed from global report interception to per-component validation at Program:exit, enabling suppression on a component-by-component basis
• Enhanced decorator usage escapes: Extended decorator-indirect-prop-usage.ts to recognize both factory patterns (track((props) => ...)(Component)) and decorator annotations (@track((props) => ...) class Component {})
• Updated React helpers: Exported new analysis functions and added isReactComponentSuperclass() to handle imported aliases like import { Component as Base }

Why: The per-component approach makes suppression logic context-aware—a prop can be a false positive for one component (where it's state) but real for another (where it's props). This isolates the new non-props check from unrelated escapes and prevents incorrect suppressions.

What reviewers should know

Where to start:

1. Review react-non-props-usage.ts first—it's the new core logic that distinguishes state/snapshot from props
2. Then check decorator.ts to see how per-component validation replaces the previous interception approach
3. Review the test changes in unit.typescript.test.ts for the main scenario: React.Component<Props, State, Snapshot> with state accessed via this.state

Key decisions:

• Per-component reporting: Each component is validated independently at the end, so suppressions can be granular. This contrasts with the previous approach that intercepted reports after the fact.
• New TypeScript-backed check: Uses the type checker to identify non-props generics, avoiding syntax-only heuristics and handling imports/aliases correctly
• Decorator annotation support: Decorator suppression now covers both track(...)(Component) factory style and @track(...) class Component {} annotation style

Watch for:

• The refactored decorator path now explicitly iterates components and applies suppressions during reporting, not during interception—verify all existing escapes (hasOwnCustomSuperclassPropsForwarding, hasForwardRefCallbackPropUsage, hasSupportedWholePropsUsage) are still checked
• Cache behavior in react-non-props-usage.ts uses WeakMap for per-source memoization—verify this doesn't cause unexpected cache retention
• One test was removed (wrapped callbacks in forwardRef). Confirm this behavior change is intentional

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

gitar auto-apply:on         

gitar display:verbose         

_{Was this helpful? React with 👍 / 👎 | Gitar}