Conversation
SharonStrats
approved these changes
Jan 31, 2022
SharonStrats
left a comment
Contributor
There was a problem hiding this comment.
I tried to help with the type errors as I know you are busy. I did not test though to see if the map would work with the sort. It does solve the Typescript errors though. My system isn't setup perfectly right now, but I can try it out tomorrow. I will check to see if you already fixed it tomorrow and if not I'll see if I can test it locally.
Contributor
|
Resolve conversations to hope make the tests run. They are blocked for one day now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aimed at fixing SolidOS/chat-pane#71