Fix typos; closes #429 - #432
Merged
Merged
Conversation
Contributor
|
Fail on lint |
TallTed
reviewed
Sep 27, 2021
| export const defaultPreferredLanguages = ['en', 'fr', 'de', 'it', 'ar'] | ||
|
|
||
| export function addDefaults (array) { | ||
| export function addDefaults(array) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export function addDefaults(array) { | |
| export function addDefaults (array) { |
TallTed
reviewed
Sep 27, 2021
| } | ||
|
|
||
| export async function getPreferredLanagugesFor (person: NamedNode) { | ||
| export async function getPreferredLanguagesFor(person: NamedNode) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export async function getPreferredLanguagesFor(person: NamedNode) { | |
| export async function getPreferredLanguagesFor (person: NamedNode) { |
TallTed
reviewed
Sep 27, 2021
| * Either from solid preferences or browser preferences or default | ||
| */ | ||
| export async function getPreferredLanguages () { | ||
| export async function getPreferredLanguages() { |
Contributor
There was a problem hiding this comment.
Suggested change
| export async function getPreferredLanguages() { | |
| export async function getPreferredLanguages () { |
TallTed
reviewed
Sep 27, 2021
| */ | ||
|
|
||
| export function filterByLanguage (bindings, languagePrefs) { | ||
| export function filterByLanguage(bindings, languagePrefs) { |
Contributor
There was a problem hiding this comment.
Suggested change
| export function filterByLanguage(bindings, languagePrefs) { | |
| export function filterByLanguage (bindings, languagePrefs) { |
TallTed
suggested changes
Sep 27, 2021
TallTed
left a comment
Contributor
There was a problem hiding this comment.
I don't know why these spaces were deleted in the first place ... but putting them back appears to be the path through the Lint error.
Contributor
Author
|
Should be good now, sorry about that. Is there a reason you have this enabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding the talked about typos in https://github.com/solid/solid-ui/issues/429