Adding public data searches using autocomplete UX to the forms system. - #391
Merged
Conversation
added 9 commits
April 3, 2021 23:35
…r autocompletePicker, includes also buttons
…in a public database by autocompleting on its name. Very early stage ... much to do still for this file.
angelo-v
marked this pull request as draft
April 10, 2021 16:36
added 16 commits
April 12, 2021 21:36
…-logic level failed horribly due to JS scope isses in a event handler
…o ESCO Api call, need more than 20
timbl
marked this pull request as ready for review
May 10, 2021 08:49
TallTed
reviewed
May 19, 2021
TallTed
left a comment
Contributor
There was a problem hiding this comment.
A few typos... Submitting as a review, to make building a followup PR easier
| let m2: string | ||
| if (err instanceof UnauthorizedError) { | ||
| m2 = 'Strange - you are not authenticated (properly logged in) to read preference file.' | ||
| m2 = 'Ooops - you are not authenticated (properly logged in) to for me to read your preference file. Try loggin out and logging in?' |
Contributor
There was a problem hiding this comment.
Suggested change
| m2 = 'Ooops - you are not authenticated (properly logged in) to for me to read your preference file. Try loggin out and logging in?' | |
| m2 = 'Ooops - you are not authenticated (properly logged in) for me to read your preference file. Try logging out and logging back in?' |
| ) | ||
| } | ||
| } else { | ||
| return select.parentNode.appendChild(errorMessageBlock(dom, 'Error updating data in select: ' + body)) |
Contributor
There was a problem hiding this comment.
Suggested change
| return select.parentNode.appendChild(errorMessageBlock(dom, 'Error updating data in select: ' + body)) | |
| return select.parentNode.appendChild(errorMessageBlock(dom, 'Error updating data in selection: ' + body)) |
Comment on lines
+78
to
+79
| callbackFunction(false, 'NO data to elete') | ||
| box.appendChild(widgets.errorMessageBlock(dom, 'Autocomplet delete: no old data!')) |
Contributor
There was a problem hiding this comment.
Suggested change
| callbackFunction(false, 'NO data to elete') | |
| box.appendChild(widgets.errorMessageBlock(dom, 'Autocomplet delete: no old data!')) | |
| callbackFunction(false, 'No data to delete') | |
| box.appendChild(widgets.errorMessageBlock(dom, 'Autocomplete delete: no old data!')) |
| /* Create and edit data using public data | ||
| ** | ||
| ** organization conveys many distinct types of thing. | ||
| ** As the data source is passed as a parameter, all kinds of APIa and query services can be used |
Contributor
There was a problem hiding this comment.
Suggested change
| ** As the data source is passed as a parameter, all kinds of APIa and query services can be used | |
| ** As the data source is passed as a parameter, all kinds of APIs and query services can be used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding public data searches using autocomplete UX to the forms system. Work in Progress.
The form field carries data source to use, including endpoints, query or API templates as strings in the form.
So you can build apps which connect people to Wikidata, etc.
A rambling breadcrumbs document describes the path to this point.