Build types - #334
Merged
Merged
Conversation
SharonStrats
self-requested a review
August 31, 2020 10:38
SharonStrats
approved these changes
Aug 31, 2020
michielbdejong
force-pushed
the
build-types
branch
from
August 31, 2020 10:40
b7a1b46 to
bbe9306
Compare
michielbdejong
added a commit
that referenced
this pull request
Aug 31, 2020
* added style sheet and functions * all styling but banner icon * ran lint fix * took out the extra banner styling * Added typedoc, started tests, and updated examples * completed examples, typedoc, typescript * added tests * Only build src/, since we can't get flattened output to lib/ working (#334) Co-authored-by: Sharon <sstratsianis@student.unimelb.edu.au> Co-authored-by: Michiel de Jong <michiel@unhosted.org> Co-authored-by: Michiel de Jong <michielbdejong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to get it to build types for
src/,test/and__mocks__/, but we also wanted the output to go to lib/index.d.ts and not lib/src/index.d.ts. We got the types to build to lib/index.d.ts but now it only buildssrc/. If someone knows how to make it check the types oftest/and__mocks__/as well, please contribute! :)