Skip to content

Possible fix after the types fix in rdflib - #304

Merged
megoth merged 4 commits into
masterfrom
rdflib-typing-fix
Apr 30, 2020
Merged

Possible fix after the types fix in rdflib#304
megoth merged 4 commits into
masterfrom
rdflib-typing-fix

Conversation

@megoth

@megoth megoth commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

This must not be merged into master before we have the new types merged into rdflib - linkeddata/rdflib.js#406

@megoth
megoth requested a review from timbl April 29, 2020 13:28
@megoth
megoth marked this pull request as draft April 29, 2020 13:28
@megoth

megoth commented Apr 30, 2020

Copy link
Copy Markdown
Contributor Author

Relies on changes in linkeddata/rdflib.js#415

@timbl

timbl commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

The checks fail at the moment with

src/widgets/buttons.ts(922,15): error TS2339: Property 'toNT' does not exist on type 'Term'.

@megoth

megoth commented Apr 30, 2020

Copy link
Copy Markdown
Contributor Author

Yeah, it's relying on the changes in the various commits. I'll let you know once it's resolved.

@megoth
megoth marked this pull request as ready for review April 30, 2020 18:56
@megoth
megoth merged commit b8027e2 into master Apr 30, 2020
@megoth
megoth deleted the rdflib-typing-fix branch April 30, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants