Skip to content

Re-enable forms tests - #255

Merged
michielbdejong merged 10 commits into
masterfrom
re-enable-forms-tests
Mar 13, 2020
Merged

Re-enable forms tests#255
michielbdejong merged 10 commits into
masterfrom
re-enable-forms-tests

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

No description provided.

@michielbdejong
michielbdejong requested a review from megoth March 13, 2020 07:47

@megoth megoth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! Quite extensive, but I request some few improvements.

Comment thread test/unit/widgets/forms.test.ts Outdated
Comment thread test/unit/widgets/forms.test.ts Outdated
Comment thread test/unit/widgets/forms.test.ts Outdated
Comment thread test/unit/widgets/forms.test.ts
@michielbdejong
michielbdejong requested a review from megoth March 13, 2020 14:14

@megoth megoth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've addressed all my concerns, so this is ready to merge when you want.

@michielbdejong
michielbdejong merged commit e48561e into master Mar 13, 2020
@timea-solid
timea-solid deleted the re-enable-forms-tests branch March 8, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants