Bump to v0.8.3 from master - #1
Merged
Merged
Conversation
This could have been added directly in `print_frame_inner`, so we only need to add it in one place. However, by adding it in `print_internal`, prior to filtering, we allow transformation and filtering to cooperate. This allows a transformer to modify a frame such that it can later be marked for filtering, which would avoid duplicated code between those functions. I don't have this use case right now, but it made sense from an overall product design perspective. This closes #227. This closes #228. Perf difference between this and #228 is nominal. Pick whichever you like more.
…ses of const std::string& to use these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.