windows replicate - #588
Merged
Merged
Conversation
| $outputVersion = @{ | ||
| "propertyBag" = $fromVersion | ||
| } | ||
| (ConvertTo-Json $outputVersion -depth 100) | Out-File -filepath "$mdFilePathTo" -Encoding ASCII |
Contributor
There was a problem hiding this comment.
Are you sure ASCII is a good choice? The source might have unicode text.
Contributor
Author
There was a problem hiding this comment.
hmm. i chose ascii because reqProc was failing to read the json when i left it at the default encoding value. but i'll investigate this more once the rest of the functionality is in.
Contributor
Author
There was a problem hiding this comment.
i've changed it to UTF8 now, which doesn't seem to cause problems, and I think that's typically what we specify in other situations.
| (ConvertTo-Json $outputVersion -depth 100) | Out-File -filepath "$mdFilePathTo" -Encoding ASCII | ||
| } else { | ||
| $toVersionJson = Get-Content -Raw -Path $mdFilePathTo | ConvertFrom-Json | ||
| # TODO: add-member doesn't seem to be working as i thought it would. |
Contributor
Author
|
merging since the comments have been addressed. @rageshkrishna let me know if you have any other concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#587