Added Python3 support - #4
Closed
JenkinsDev wants to merge 1 commit into
Closed
Conversation
Contributor
|
Wow. Thanks! Will have to do some of my own tests before I merge this, due diligence and all that. But still, thanks for the patch, really thorough! |
Contributor
Author
|
Sounds great! No problem at all 👍 |
Contributor
Author
|
It's been quite awhile and I was just wondering if there seemed to be any issues with the Python 3 port? Is there something I can fix up or has testing and merging just slipped your mind over time? Thanks again :) |
Contributor
|
Hey! I've merged it into a new python3 branch, so everyone can get what they want. Thanks again for the pull request (and reminding me about it!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and added Python3 support for the semantics library and per our conversation I changed the OAuth library to support requests-oauthlib instead.