find-bar: change placeholder when switching tabs - #9137
Open
mxmou wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for changes
From feedback:
We already have costume search in the find bar addon, but it's possible that people don't realize that - since the addon is enabled by default, they might not ever read its description. In addition, the placement next to the tab bar and not inside the active tab doesn't make it obvious that the find bar's function changes depending on which tab is selected. I remember initially thinking that it was only for searching code.
Changes
Changes the input placeholder to "Find", "Find costume", or "Find sound", depending on which tab is selected. This should make it clear that the find bar can be used to find costumes and sounds.
Tests
Tested on Edge.