Skip to content

Add dynamic enable, disable, and settings changes to cat-blocks - #7589

Merged
mxmou merged 6 commits into
ScratchAddons:masterfrom
TheColaber:refesh-cats
Aug 6, 2025
Merged

Add dynamic enable, disable, and settings changes to cat-blocks#7589
mxmou merged 6 commits into
ScratchAddons:masterfrom
TheColaber:refesh-cats

Conversation

@TheColaber

Copy link
Copy Markdown
Member

I tried fixing the "Watch Mouse Pointer" setting since it's pretty buggy in RTL and when using zoom. I couldn't figure it out so hopefully someone smarter than me (cough @GarboMuffin) can fix it or maybe in another PR in the future.

Also, should this addon still say it uses the "scratch-blocks" library in the manifest?

@mxmou

mxmou commented Jun 25, 2024

Copy link
Copy Markdown
Member

Also, should this addon still say it uses the "scratch-blocks" library in the manifest?

Yes, because it contains (modified) code from scratch-blocks.

@WorldLanguages

Copy link
Copy Markdown
Member

Related: (link: #5604 (comment))

This only works properly because cat blocks can't be dynamically enabled/disabled, right?

@TheColaber

Copy link
Copy Markdown
Member Author

Related: (link: #5604 (comment))

This only works properly because cat blocks can't be dynamically enabled/disabled, right?

I believe that addon should be able to work without using getEnabledAddons. It could probably call some block functions that cat blocks pollute and work based on that.

@Samq64 Samq64 added the scope: addon Related to one or multiple addons label Jun 30, 2024
@Samq64

Samq64 commented Jul 12, 2024

Copy link
Copy Markdown
Member

Changing the setting dynamically doesn't seem to effect the block palette.

@TheColaber

Copy link
Copy Markdown
Member Author

#5604 (comment)

@TheColaber
TheColaber requested a review from Samq64 September 4, 2024 04:12
@TheColaber

Copy link
Copy Markdown
Member Author

update: waiting on #7783

@TheColaber TheColaber added the status: pending A PR is still not ready to merge, or an issue is being worked on/on consideration label Sep 5, 2024
@Samq64 Samq64 removed the status: pending A PR is still not ready to merge, or an issue is being worked on/on consideration label Dec 16, 2024
@Samq64

Samq64 commented Feb 4, 2025

Copy link
Copy Markdown
Member

#7783 has been merged.

@mxmou
mxmou merged commit b00c520 into ScratchAddons:master Aug 6, 2025
3 checks passed
@mxmou
mxmou removed the request for review from Samq64 August 6, 2025 11:39
@WorldLanguages

Copy link
Copy Markdown
Member

Potential regression: #8530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants