blocks2image: modal instead of menu items & new "copy to clipboard" - #6830
Conversation
|
Maybe you could add an "as PNG/SVG" to the end of the options? |
|
any word on this? |
I'm not convinced about adding so many items to the right click menu, this is also related to #4919 |
We should bundle all of the script snapshot-related options in a dropdown menu if possible. |
Co-authored-by: Maximouse <51849865+mxmou@users.noreply.github.com>
A dropdown menu in the right click menu? |
Yes, that's what I meant. |
|
im not going to mess with the API at this stage so if anyone feels the need to implement this, go ahead lol |
Samq64
left a comment
There was a problem hiding this comment.
I have a few minor nitpicks but everything works fine.
|
An alternative to the submenu could be to have settings to turn of some of the options, but it's just 2 more items. |
|
Could the description also mention copying? |
Sure, do you have a suggestion? |
How about "Right click the code area to copy block images to clipboard, or download them as an SVG or PNG."? |
Maybe we could hide this by default (and make the 2 new buttons a setting) until we can figure out how to handle submenus? After this becomes a submenu we can just enable it for everyone and it won't take any more extra space. |
I have a 1600p screen so maybe that small difference is enough. I'm pretty sure there is css I can do to make sure the buttons stay at the bottom no matter what, I thought I did but I'll look at it another time. Can't rn, so @WorldLanguages please remind me on discord in about 9 hours. |
|
@mxmou If you have some time maybe you can help with the CSS of the modal to avoid the bug I mentioned yesterday. |
I can't test this right now, but I think making |
|
On the modal header: I have no idea why this works so its a bad idea. But it does work, so its worth sending here? Mxmou's suggestion doesn't work without a min-width, and doesn't work well with it. I am not sure why there is not a simple solution to this? This is essentially a footer, yet it seems to not work the same. |
You can push the code, then I'll try to improve it when I have time. |
|
Ping! There has been no activity for 7 days. |
|
Ping! There has been no activity for 7 days. |
|
Can someone please approve this update so that it will be available in the next release? Thanks in advance. |
|
@sfederici No, this is planned for v1.40 |
|
Ping! There has been no activity for 7 days. |
Co-authored-by: Samq64 <81489795+Samq64@users.noreply.github.com>
|
How do I copy SVG to clipboard? |
This is not useful enough to be added, as of now you can not copy the svg to your clipboard. The clipboard is not designed for that amount of data in that format (essentially text). |
Resolves #6823 and also my own suggestion
Resolves #6096
Changes
Lets you right click to copy the image of blocks to your clipboard
Reason for changes
Convenience
Tests
Tested on chrome and unlike the embarassment of my last pr im pretty sure there are no problems