Skip to content

scratch-notifier: do not play ping sound for disabled notifications - #4192

Merged
WorldLanguages merged 1 commit into
ScratchAddons:masterfrom
apple502j:fix-notifier-ping
Feb 6, 2022
Merged

scratch-notifier: do not play ping sound for disabled notifications#4192
WorldLanguages merged 1 commit into
ScratchAddons:masterfrom
apple502j:fix-notifier-ping

Conversation

@apple502j

Copy link
Copy Markdown
Member

Resolves #4191

@apple502j apple502j added priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons bug: regression Bugs that are a software regression labels Feb 5, 2022
@WorldLanguages
WorldLanguages merged commit 5cb1a44 into ScratchAddons:master Feb 6, 2022
lisa-wolfgang added a commit to lisa-wolfgang/ScratchAddons that referenced this pull request Feb 9, 2022
commit c989b27
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Tue Feb 8 00:46:08 2022 +0900

    scratch-messaging: hide Delete when inapplicable

commit ed7c169
Author: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>
Date:   Mon Feb 7 11:03:38 2022 +0900

    New strings from Transifex (ScratchAddons#4222)

    Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>

commit a74ebca
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Sun Feb 6 22:22:10 2022 +0900

    Lint 20220206 (ScratchAddons#4220)

    * Fix lint error

    * Fix typo

commit 9f50595
Author: Norbiros <89837724+Norbiros@users.noreply.github.com>
Date:   Sun Feb 6 13:56:30 2022 +0100

    Error with not showing loading message (ScratchAddons#4219)

    * Fixed problem with not showing loading message

    * Now you can see message about loading page (ScratchAddons#4215)

commit a42d637
Author: Maximouse <51849865+mxmou@users.noreply.github.com>
Date:   Sun Feb 6 11:11:53 2022 +0100

    2.0 → 3.0: fix delete account confirmation page (ScratchAddons#4218)

commit 2346451
Author: Maximouse <51849865+mxmou@users.noreply.github.com>
Date:   Sun Feb 6 11:11:07 2022 +0100

    Fix code blocks inside quotes again (ScratchAddons#4216)

    * Fix code blocks inside quotes again

    * Format code

    Co-authored-by: mxmou <mxmou@users.noreply.github.com>

commit 58eec51
Author: GarboMuffin <muffin@muffin.ink>
Date:   Sun Feb 6 03:59:32 2022 -0600

    editor-stepping: Don't spew errors if workspace is null (ScratchAddons#4214)

commit 1f94c03
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Sun Feb 6 10:04:41 2022 +0900

    Make getBlockly error more detailed for debugging purposes (ScratchAddons#4213)

commit c57aa45
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Sun Feb 6 09:36:21 2022 +0900

    More messaging refactor (ScratchAddons#4194)

    * scratch-messaging: refactor tooltips, more detailed error

    * Add Scratch Addons icon to fullscreen popup

commit 5cb1a44
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Sun Feb 6 09:32:43 2022 +0900

    scratch-notifier: do not play ping sound for disabled notifications (ScratchAddons#4192)

commit f2e4b1c
Author: GarboMuffin <33787854+GarboMuffin@users.noreply.github.com>
Date:   Sat Feb 5 15:13:00 2022 -0600

    debugger: fix go to block (ScratchAddons#4178)

commit cec09dd
Author: GarboMuffin <33787854+GarboMuffin@users.noreply.github.com>
Date:   Sat Feb 5 15:08:50 2022 -0600

    Fix _step trap race affecting clones and variable-manager (ScratchAddons#4190)

    * clones: fix ScratchAddons#4184

    * variable-manager: fix similar problem to ScratchAddons#4184

commit c616b08
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Sat Feb 5 15:10:11 2022 +0900

    Bump to 1.24.2-pre (ScratchAddons#4193)

commit 6228ad1
Author: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>
Date:   Fri Feb 4 13:42:33 2022 +0900

    New strings from Transifex (ScratchAddons#4177)

    Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>

commit 570a232
Author: World_Languages <mundofinky@gmail.com>
Date:   Wed Feb 2 22:37:37 2022 -0300

    Bump to v1.24.1 stable (ScratchAddons#4174)

commit 37c052f
Author: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>
Date:   Wed Feb 2 22:14:59 2022 -0300

    New strings from Transifex (ScratchAddons#4173)

    Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>

commit 60aab10
Author: Maximouse <51849865+mxmou@users.noreply.github.com>
Date:   Thu Feb 3 02:12:04 2022 +0100

    Attempt to fix broken profile layout on macOS (ScratchAddons#4156)

commit f730cb5
Author: Maximouse <51849865+mxmou@users.noreply.github.com>
Date:   Thu Feb 3 02:07:23 2022 +0100

    Fix My Stuff tab problems (ScratchAddons#4168)

commit 8d384cc
Author: Maximouse <51849865+mxmou@users.noreply.github.com>
Date:   Thu Feb 3 02:06:07 2022 +0100

    Fix featured project title overflow (ScratchAddons#4169)

commit 58f0ba3
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Thu Feb 3 10:05:47 2022 +0900

    scratchr2: fix z-index (ScratchAddons#4166)

commit 2f6487b
Author: apple502j <33279053+apple502j@users.noreply.github.com>
Date:   Wed Feb 2 23:13:16 2022 +0900

    Bump to 1.24.1-pre (ScratchAddons#4165)

commit e5eeda4
Author: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>
Date:   Wed Feb 2 11:49:19 2022 +0900

    New strings from Transifex (ScratchAddons#4162)

    Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>

commit f8f112f
Author: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>
Date:   Mon Jan 31 19:50:05 2022 -0500

    New strings from Transifex (ScratchAddons#4152)

    Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com>

commit a6d4e8f
Author: World_Languages <mundofinky@gmail.com>
Date:   Mon Jan 31 20:17:41 2022 -0300

    Bump to v1.24.0 stable (ScratchAddons#4151)

commit 05f044c
Author: World_Languages <mundofinky@gmail.com>
Date:   Mon Jan 31 20:13:38 2022 -0300

    Add YouTube video to update notification (ScratchAddons#4150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: regression Bugs that are a software regression priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SA ping sound plays when receiving disabled notification

2 participants