Hide inputs when custom block middle clicked - #3961
Conversation
|
Using the block flasher from devtools in debugger makes code cleaner but I want to double check whether we introduced some different logic for debugger and forgot |
|
Devtools' |
the state of the devtools addon code at that time could not be a simple import. The best way was to copy the code and leave a comment. |
That's what I thought, but it looks like that's not the case? Go to the commit I linked to, browse files, addons→editor-devtools→blockly and there it is, BlockFlasher.js! |
apple502j
left a comment
There was a problem hiding this comment.
LGTM, but has one question. (note to future self: reusing DevtoolsUtils could have issue on re-entering, so this code is correct)
| } | ||
|
|
||
| _flash(); | ||
| const { scrollBlockIntoView } = new DevtoolsUtils(addon); |
Well, I guess we didn't realize it. |
Resolves TurboWarp/scratch-gui#390
Changes
Blockly.hideChaff(), which scratch also uses for gestures: https://github.com/LLK/scratch-blocks/blob/893c7e7ad5bfb416eaed75d9a1c93bdce84e36ab/core/gesture.js#L483
I also import the devtools code to the debugger addon since they use the exact same code for going to a block and blinking it.