Implement Tab.createEditorContextMenu - #3429
Merged
Merged
Conversation
TheColaber
reviewed
Sep 5, 2021
Member
|
TODOs:
|
Member
Author
|
@WorldLanguages Requesting re-review; also @GarboMuffin for folders change and compat Not sure if I want to mess with folders addon in this PR. Maybe as a future refactoring PR. |
Member
|
Folders change looks okay |
TheColaber
requested changes
Sep 10, 2021
Member
|
Shouldn't most references to "context menu" in the code, including the function name, actually be called "context menu item"? |
Member
|
Yeah, it is this way to be consistent with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3406
Closes #3418
Resolves #3439
Also adds new addon "Move costume to top or bottom" (move-to-top-bottom) - a testing addon but this can be kept.