editor-devtools: add Alt + Click as middle-click alternative - #3171
Merged
WorldLanguages merged 1 commit intoJul 31, 2021
Merged
Conversation
Contributor
|
Don't worry about TX.
…________________________________
From: lisa-wolfgang ***@***.***>
Sent: Friday, July 30, 2021 3:04:43 PM
To: ScratchAddons/ScratchAddons ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [ScratchAddons/ScratchAddons] editor-devtools: add Alt + Click as middle-click alternative (#3171)
Resolves #2321<#2321> (specifically #2321 (comment)<#2321 (comment)>)
Changes
Alt + Click is now capable of triggering the middle-click popup and the "jump to" feature.
The help modal has also been tweaked to accommodate this change. I don't know if I'm supposed to change the strings in Transifex or not, and I don't have access to Transifex anyway, so I just changed them in addons-l10n/en/editor-devtools.json for now.
Reason for changes
Currently, for users without a mouse or a touchpad where a triple-finger-tap simulates a middle-click, the "jump to" feature is unusable.
It's available for the middle-click popup as well for simplicity code-wise and consistency.
I would have just used Ctrl + Space, but it may have caused issues for existing Ctrl + Space users using the shortcut with their cursor inadvertently positioned over a block.
Tests
Tested in Chromium 92 and Firefox 90.
Middle-clicking and Ctrl + Space are unaffected by this change.
________________________________
You can view, comment on, or merge this pull request online at:
#3171
Commit Summary
* Initial commit
File Changes
* M addons-l10n/en/editor-devtools.json<https://github.com/ScratchAddons/ScratchAddons/pull/3171/files#diff-1748b451da5a9e4fe32e993e335b7c983ecf6283b88039121f00363c8f012032> (6)
* M addons/editor-devtools/DevTools.js<https://github.com/ScratchAddons/ScratchAddons/pull/3171/files#diff-43d928c2d28cbb183b4bd0e3404ded341647def6274253ba7e5aa36036596ad2> (2)
Patch Links:
* https://github.com/ScratchAddons/ScratchAddons/pull/3171.patch
* https://github.com/ScratchAddons/ScratchAddons/pull/3171.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3171>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DEWKLPMETOY4A6UJDX3T2MAVXANCNFSM5BJEMDYA>.
|
Contributor
so you have pure chromium (apt install chromium)? |
Member
Author
No, a Chromium-based browser -- more specifically, Brave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2321 (specifically #2321 (comment))
Changes
Alt + Click is now capable of triggering the middle-click popup and the "jump to" feature.
The help modal has also been tweaked to accommodate this change. I don't know if I'm supposed to change the strings in Transifex or not, and I don't have access to Transifex anyway, so I just changed them in
addons-l10n/en/editor-devtools.jsonfor now.Reason for changes
Currently, for users without a mouse or a touchpad where a triple-finger-tap simulates a middle-click, the "jump to" feature is unusable.
It's available for the middle-click popup as well for simplicity code-wise and consistency.
I would have just used Ctrl + Space, but it may have caused issues for existing Ctrl + Space users using the shortcut with their cursor inadvertently positioned over a block.
Tests
Tested in Chromium 92 and Firefox 90.
Middle-clicking and Ctrl + Space are unaffected by this change.