Skip to content

editor-stage-left: rewrite fix-share-the-love without urlChange - #3089

Merged
apple502j merged 1 commit into
ScratchAddons:masterfrom
GarboMuffin:cleanup-left
Jul 24, 2021
Merged

editor-stage-left: rewrite fix-share-the-love without urlChange#3089
apple502j merged 1 commit into
ScratchAddons:masterfrom
GarboMuffin:cleanup-left

Conversation

@GarboMuffin

Copy link
Copy Markdown
Member

Just cleans up some old code and fixes some potential uncaught errors.

  • replace urlChange, editorMode, and setInterval with getBlockly
  • fixes dynamic enable/disable throwing error if workspace does not exist (don't think this actually broke anything)
  • should work slightly more reliably

@apple502j apple502j added priority: 4 Low priority. Includes minor bugs and less important features scope: addon Related to one or multiple addons scope: tech debt Related to technical debt labels Jul 24, 2021
@apple502j
apple502j merged commit 6e85894 into ScratchAddons:master Jul 24, 2021
apple502j pushed a commit to apple502j/ScratchAddons that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: 4 Low priority. Includes minor bugs and less important features scope: addon Related to one or multiple addons scope: tech debt Related to technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants