editor-searchable-dropdowns: fix a couple bugs - #3083
Merged
apple502j merged 2 commits intoJul 23, 2021
Conversation
GarboMuffin
commented
Jul 23, 2021
Member
- Fixes broken dropdowns when no menu item is selected (for example, when the selected costume was deleted) https://discord.com/channels/806602307750985799/806602307750985803/867883445517942795
- Fix selecting "Create variable xyz" menu items requiring 2 ctrl+z to be fully undone (now only 1)
GarboMuffin
force-pushed
the
searchable-dropdowns3
branch
from
July 23, 2021 02:25
8c62ce0 to
3a22da7
Compare
apple502j
pushed a commit
to apple502j/ScratchAddons
that referenced
this pull request
Jul 26, 2021
* editor-searchable-dropdowns: fix error when selectedItem is null * editor-searchable-dropdowns: allow fully reverting with one ctrl+z (cherry picked from commit b0fc02a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.