Skip to content

allow fps lower then 31 to 60fps - #2784

Closed
Shluffy wants to merge 7 commits into
ScratchAddons:masterfrom
Shluffy:untitled-branch
Closed

allow fps lower then 31 to 60fps#2784
Shluffy wants to merge 7 commits into
ScratchAddons:masterfrom
Shluffy:untitled-branch

Conversation

@Shluffy

@Shluffy Shluffy commented Jun 15, 2021

Copy link
Copy Markdown

Resolves #2778 Fixes Slow-mo part of #2760 resolves #1963

Changes

change the addon.json file to have the minimum be 1, changes description and changes name to be "custom fps player mode"

Reason for changes

because this is just the opposite that makes sense to have

Tests

I have not tested this.

@Shluffy
Shluffy requested a review from WorldLanguages as a code owner June 15, 2021 14:51
@cobaltt7

Copy link
Copy Markdown
Contributor

Changing the name and desc is fine IMO, just not the id.

@Shluffy
Shluffy marked this pull request as draft June 15, 2021 15:00
@Shluffy

Shluffy commented Jun 15, 2021

Copy link
Copy Markdown
Author

All right, ty. I will change it

@cobaltt7

Copy link
Copy Markdown
Contributor

Resolves #1963

@Shluffy

Shluffy commented Jun 15, 2021

Copy link
Copy Markdown
Author

@RedGuy12 is the name fine to change, just not the id?

@cobaltt7 cobaltt7 linked an issue Jun 15, 2021 that may be closed by this pull request
@cobaltt7

Copy link
Copy Markdown
Contributor

@RedGuy12 is the name fine to change, just not the id?

That's what I said.

@Shluffy
Shluffy marked this pull request as ready for review June 15, 2021 15:06
with out grammerly
Comment thread addons/60fps/addon.json Outdated
Comment thread addons/60fps/addon.json Outdated
Comment thread addons/60fps/addon.json Outdated
mxmou added a commit to mxmou/ScratchAddons that referenced this pull request Jun 28, 2021
@WorldLanguages

Copy link
Copy Markdown
Member

is this going to be like this 4ever?

I'll review this in a few days, I'm taking a little break

... lowercase.
@WorldLanguages

Copy link
Copy Markdown
Member

IMO slow down / go faster buttons would be very useful, but they should be part of another addon. I don't think letting users enter less than 30 FPS on this addon makes sense. It would fix the problem temporarily, but don't forget this addon is enabled by default and 99% of its users will keep it at fixed 60

@WorldLanguages

Copy link
Copy Markdown
Member

If you want to achieve this currently, you can run this in the settings page:

vue.addonSettings["60fps"].framerate = 19
vue.updateSettings(vue.manifestsById["60fps"])

@Shluffy
Shluffy deleted the untitled-branch branch July 5, 2021 15:36
WorldLanguages added a commit that referenced this pull request Jul 28, 2021
* Use more consistent language

* Use the word "save" which was previously in the addon name in blocks2image description

* Use extended search & other changes to allow searching by old addon names

* Some changes suggested by @apple502j

* Revert a change

* More changes based on suggestions

* Revert 60 FPS change - #2784 is better

* ocular integration

* Better image-uploader description

Based on @RedGuy12's suggestion

* Clarify mouse-pos description as requested by @WorldLanguages

* Improve studio-tools description

Based on @RedGuy12's suggestion

* paint editor → costume editor

* stack → script

* Improve recently added addon descriptions

* "Add extension" is used by Scratch

* (forum-time-zones) Use grammatically correct description by mxmou

* (my-ocular) Full domain in addon name

* image-uploader: upload -> upload and insert

* Remove Alt+GreenFlag from 60fps addon name

Co-authored-by: WorldLanguages <mundofinky@gmail.com>
Co-authored-by: apple502j <33279053+apple502j@users.noreply.github.com>
@return-misaPuding

Copy link
Copy Markdown

This is a useful feature that some people experimenting with and debugging some enhanced scratch projects could use and won´t harm other users (because as you already said, almost all of them (even me) don't even change the FPS and the ones which do so just won't set it to FPS lower than 30 unless they want it for some reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have projects move slower addon Rename "60FPS player mode"

6 participants