Skip to content

Add two new settings to editor dark mode - #2699

Merged
apple502j merged 3 commits into
ScratchAddons:masterfrom
mxmou:two-new-settings
Jun 9, 2021
Merged

Add two new settings to editor dark mode#2699
apple502j merged 3 commits into
ScratchAddons:masterfrom
mxmou:two-new-settings

Conversation

@mxmou

@mxmou mxmou commented Jun 7, 2021

Copy link
Copy Markdown
Member

Resolves #2415
Adds a feature described in #1805 (comment)

Changes

  • Adds the Boolean setting described in Bring back the dark lists & variables but as an option #2415
  • Adds a setting to change the color of blue text and icons (ideally the tool buttons in the paint editor would also be affected but those icons also use other colors and I'm not sure if there is an SVG filter that would only affect a specific color)
  • Makes the selection background and handles in the sound editor affected by the highlight color setting
  • Removes now unused camera modal styles

addon.json change

There is a new type for custom CSS variables, "recolorFilter", which returns a filter function that can be used to change the color of monochrome icons.

Reason for changes

To allow more customization.

Tests

Tested with different values of both settings.

@mxmou
mxmou requested a review from WorldLanguages as a code owner June 7, 2021 10:14

@WorldLanguages WorldLanguages left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged

@apple502j apple502j added priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons scope: addon.json About the addon.json file structure labels Jun 9, 2021
@apple502j
apple502j merged commit 0fc0bb0 into ScratchAddons:master Jun 9, 2021
@mxmou
mxmou deleted the two-new-settings branch July 9, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: 3 Medium priority. Includes bugs and useful features scope: addon.json About the addon.json file structure scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring back the dark lists & variables but as an option

3 participants