Add reduxCondition to more addons - #2508
Merged
Merged
Conversation
Contributor
|
Some conditions for addons that interact with project comments were removed in #2493 because the same code will run on www studio comments, which doesn't have redux |
Member
Author
The new www studio comments will have redux. All scratch-www pages have redux, even contact-us does. It shouldn't be a problem anyways because everything that can run on those pages checks |
Member
|
Note that reduxCondition is fool-proof so even if we run it on scratchr2 page that should be fine. |
Member
|
TODO: check URL matches for true-youtube-links, probably shouldn't be wildcard |
FunctionalMetatable
added a commit
to FunctionalMetatable/ScratchAddons
that referenced
this pull request
May 19, 2021
* New strings from Transifex (ScratchAddons#2519) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Add reduxCondition to more addons (ScratchAddons#2508) * comments-linebreaks * remix-tree-button * more-links * infinite-scroll * copy-message-link * true-youtube-links * better-emojis * Update better-emojis * fix copy-message-link on non-project pages * editor-devtools: fix some bugs (ScratchAddons#2474) * editor-devtools: make switching between receivers across sprites more reliable * editor-devtools: disable middle mouse default behavior For Linux systems where middle mouse = paste * editor-devtools: fix mouse position being incorrect sometimes * editor-devtools: fix floating block palette after leaving custom procedure creator * editor-devtools: Allow interacting with the floating block palette with a mouse * fix pressing enter to select blocks * fix confirm actions button (ScratchAddons#2441) * New strings from Transifex (ScratchAddons#2529) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * data-category-tweaks-v2: use real blockly (ScratchAddons#2528) * Rewrite on real blockly * Still have to do a manual workspace update * Update comment * Color picker fixes (ScratchAddons#2370) * Bump color-picker * Update README.md * Bump again * Update README.md * Update README.md * Update index.js * style: format code Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> * Change default msg-count-badge color, make it customizable (ScratchAddons#2430) * Support Scratch Team Alerts (ScratchAddons#2431) * init commit * style: format code * parse message as html instead of text * Make dismiss alert work, UI changes * style: format code * add back wl's comment * Fix dismiss sometimes not working * There is no reason, I just didn't think about it then Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> * Update icons.css (ScratchAddons#2437) * Ask before closing a topic in the forums (ScratchAddons#2455) * code * style: format code * addon.json * l10n * use "Confirm closing forum topics" instead of "Confirm closing topics" * Remove "studios" and "forums" tags Co-authored-by: FunctionalMetatable <FunctionalMetatable@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> * Format code Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> Co-authored-by: GarboMuffin <33787854+GarboMuffin@users.noreply.github.com> Co-authored-by: GrahamSH <grahamshllk@gmail.com> Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> Co-authored-by: World_Languages <mundofinky@gmail.com> Co-authored-by: TheColaber <72760579+TheColaber@users.noreply.github.com> Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> Co-authored-by: Secret-chest <74449186+Secret-chest@users.noreply.github.com> Co-authored-by: FunctionalMetatable <FunctionalMetatable@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I missed some addons in #2268
This adds reduxCondition and similar optimizations to:
Has been at least briefly tested