Skip to content

Add dark presets to theme3 - #2207

Merged
WorldLanguages merged 54 commits into
ScratchAddons:masterfrom
mxmou:dark-block-colors
Apr 25, 2021
Merged

Add dark presets to theme3#2207
WorldLanguages merged 54 commits into
ScratchAddons:masterfrom
mxmou:dark-block-colors

Conversation

@mxmou

@mxmou mxmou commented Apr 18, 2021

Copy link
Copy Markdown
Member

Resolves

Resolves #1806
Resolves #2095

Changes

Multiple changes to customizable block colors:

  • a new setting to change the background color of block inputs
  • a new setting to change the text color to black or colored on black/white background
  • two new presets designed to be used with editor dark mode:
    • image
    • image

None of these changes are very important so this can (should) be merged after the release.

Reason for changes

#1805 (comment)

Tests

Tested on Chrome and Firefox.

mxmou and others added 30 commits March 10, 2021 19:55
@mxmou mxmou added the scope: addon Related to one or multiple addons label Apr 18, 2021
@mxmou
mxmou requested a review from WorldLanguages as a code owner April 18, 2021 13:30
@mxmou

mxmou commented Apr 18, 2021

Copy link
Copy Markdown
Member Author

This contains commits from #1805 because I started working on it before #1805 was merged.

@mxmou
mxmou marked this pull request as draft April 20, 2021 17:29
@WorldLanguages

Copy link
Copy Markdown
Member

@mxmou Should I wait until this is not a draft to review?

@mxmou

mxmou commented Apr 24, 2021

Copy link
Copy Markdown
Member Author

@WorldLanguages I still need to remove the changes I made to the auto refresh code in the userscript while working on this, but the rest is done.

@mxmou

mxmou commented Apr 24, 2021

Copy link
Copy Markdown
Member Author

All presets now define all colors, because the previous behavior was confusing.

@mxmou
mxmou marked this pull request as ready for review April 24, 2021 07:35
Comment thread webpages/settings/index.html
@WorldLanguages
WorldLanguages merged commit 1b785a4 into ScratchAddons:master Apr 25, 2021
@WorldLanguages

Copy link
Copy Markdown
Member

@mxmou Do you think we should mark the addon as "new" for v1.14.0 so that people notice the presets? 🤔
Or do you have any better ideas on how to handle this for the feature
Maybe an "updated addons" group on the settings page, that lets us describe the update?

@cobaltt7

cobaltt7 commented May 2, 2021

Copy link
Copy Markdown
Contributor

I think we should rename the "New" group to "New and updated"

@WorldLanguages

Copy link
Copy Markdown
Member

I think we should rename the "New" group to "New and updated"

Yeah, not now, but maybe for next release

@cobaltt7

cobaltt7 commented May 2, 2021

Copy link
Copy Markdown
Contributor

I think we should rename the "New" group to "New and updated"

Yeah, not now, but maybe for next release

but if we did it now, addons like cat blocks, ocular, and this one would fit into the category a bit more

@mxmou

mxmou commented May 3, 2021

Copy link
Copy Markdown
Member Author

@WorldLanguages If we don't do that now (I think a separate "updated" category is better), I think we should mark theme3 and ocular as new because they have important new features.

@ZenithRogue

Copy link
Copy Markdown
Contributor

@mxmou

All presets now define all colors, because the previous behavior was confusing.

The presets don't need to change all the settings. This was an intentional feature of the presets. It allows you to change only groups of the needed settings, while not resetting other user values

@mxmou

mxmou commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

@ZenithRogue I think all presets should affect the same group of settings. Previously choosing "2.0 Colors", then "3.0 Tweaks" would use the original 2.0 colors for everything except events, control, and custom blocks, which is likely not what any user wanted. The addition of these new presets made things even more confusing, because switching to "Dark", then "Black" (many people would probably do this when playing with the settings because the two presets were next to each other) made the text almost black on a black background.

I agree that the ability to leave certain settings unchanged when switching presets is sometimes useful - I don't want #2415 to be affected by presets - but I don't think it makes sense in this addon, especially because users can now use the reset button to only load certain colors from a preset.

@mxmou
mxmou deleted the dark-block-colors branch June 7, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: addon Related to one or multiple addons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension block error in developer tools Block dropdowns menus and connected comment outlines having the wrong color

4 participants