Skip to content

Dark embedded projects - #2042

Merged
WorldLanguages merged 1 commit into
ScratchAddons:masterfrom
mxmou:dark-embeds
Apr 8, 2021
Merged

Dark embedded projects#2042
WorldLanguages merged 1 commit into
ScratchAddons:masterfrom
mxmou:dark-embeds

Conversation

@mxmou

@mxmou mxmou commented Apr 1, 2021

Copy link
Copy Markdown
Member

Resolves

Resolves #2039

Changes

Adds dark mode to embedded projects. This is intentionally part of website dark mode, not editor dark mode, because the place where most users see embeds are profile pages (live featured project).

Also removes a few lines of unused CSS.

@mxmou
mxmou requested a review from WorldLanguages as a code owner April 1, 2021 08:08
@mxmou

mxmou commented Apr 1, 2021

Copy link
Copy Markdown
Member Author

What's wrong with schema validation right now?

@danielgallab

Copy link
Copy Markdown
Member

cc @Hans5958 this has been happening to some PRs... there might be something that changed...

@Hans5958

Hans5958 commented Apr 1, 2021

Copy link
Copy Markdown
Member

cc @Hans5958 this has been happening to some PRs... there might be something that changed...

I saw it, inspected the schema, fixed it, and re-run the check. It's now green as grass. Sorry for the inconvenience.

@WorldLanguages
WorldLanguages merged commit 047ed5b into ScratchAddons:master Apr 8, 2021
@mxmou mxmou mentioned this pull request Apr 13, 2021
4 tasks
@mxmou
mxmou deleted the dark-embeds branch April 25, 2021 08:52
@mxmou
mxmou removed the request for review from WorldLanguages March 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode doesn't run on embed pages

5 participants