support Mac command key in mute project player by scratchusernamemrtbts · Pull Request #1923 · ScratchAddons/ScratchAddons

scratchusernamemrtbts · 2021-03-19T13:27:28Z

Resolves

Resolves #1891

Changes

make the mute project player add-on support command key on Mac
Reason for changes

Mac user can't use control key to mute because it is right click on Mac
Tests

yes
here is a video

2564-03-19.20.24.51.mov

Pull commit

support cmd key

Explosion-Scratch · 2021-03-19T13:28:59Z

(why are links red tho)

scratchusernamemrtbts · 2021-03-19T13:29:30Z

my add-on setting set the link to red

cobaltt7 · 2021-03-19T13:30:12Z

(why are links red tho)

it's a 2.0 -> 3.0 setting

scratchusernamemrtbts · 2021-03-19T13:32:52Z

put this in a json file and upload to the add-on
you're link should be red too

{"core":{"lightTheme":false,"version":"1.11.0"},"addons":{"60fps":{"enabled":true,"settings":{"framerate":"60"}},"a11y":{"enabled":true,"settings":{"tabNav":true}},"account-settings-capitalize":{"enabled":true,"settings":{}},"animated-thumb":{"enabled":true,"settings":{"persistentThumb":true}},"better-emojis":{"enabled":true,"settings":{}},"better-featured-project":{"enabled":true,"settings":{}},"better-quoter":{"enabled":true,"settings":{}},"bitmap-copy":{"enabled":true,"settings":{}},"block-switching":{"enabled":true,"settings":{"border":true,"control":true,"data":true,"event":true,"extension":true,"looks":true,"motion":true,"noop":true,"operator":true,"sensing":true,"sound":true}},"cat-blocks":{"enabled":true,"settings":{}},"clones":{"enabled":true,"settings":{}},"cloud-games":{"enabled":true,"settings":{}},"color-picker":{"enabled":true,"settings":{}},"comments-linebreaks":{"enabled":true,"settings":{}},"confirm-actions":{"enabled":true,"settings":{"followinguser":true,"joiningstudio":false,"projectsharing":true}},"copy-message-link":{"enabled":true,"settings":{}},"curator-link":{"enabled":true,"settings":{"styleAsNormalText":false}},"dark-www":{"enabled":true,"settings":{"selectedMode":"experimental-dark"}},"data-category-tweaks-v2":{"enabled":true,"settings":{"moveReportersDown":false,"separateListCategory":true,"separateLocalVariables":true}},"disable-auto-save":{"enabled":false,"settings":{}},"discuss-button":{"enabled":true,"settings":{"buttonName":"Discuss","removeIdeasBtn":false}},"editor-colored-context-menus":{"enabled":true,"settings":{}},"editor-dark-mode":{"enabled":true,"settings":{"selectedMode":"3-darker","textShadow":true}},"editor-devtools":{"enabled":true,"settings":{}},"editor-messages":{"enabled":true,"settings":{}},"editor-searchable-dropdowns":{"enabled":true,"settings":{}},"editor-stage-left":{"enabled":false,"settings":{}},"editor-stepping":{"enabled":true,"settings":{}},"editor-theme3":{"enabled":true,"settings":{"Pen-color":"#0FBD8C","control-color":"#FFBF00","custom-color":"#5f49d8","data-color":"#FF8C1A","data-lists-color":"#FF661A","events-color":"#DE9E2E","looks-color":"#9966FF","motion-color":"#4C97FF","operators-color":"#59C059","sensing-color":"#5CB1D6","sounds-color":"#CF63CF"}},"exact-count":{"enabled":true,"settings":{"forumuser":true,"studio":true,"user":true}},"feature-unshared":{"enabled":true,"settings":{}},"fix-uploaded-svgs":{"enabled":true,"settings":{}},"forum-quote-code-beautifier":{"enabled":true,"settings":{"bordercolor":"#28A5DA"}},"forum-search":{"enabled":true,"settings":{}},"forum-time-zones":{"enabled":true,"settings":{}},"full-signature":{"enabled":true,"settings":{"signature":true,"whathappen":true,"whatworkingon":true}},"hide-flyout":{"enabled":true,"settings":{"speed":"default","toggle":"cathover"}},"image-uploader":{"enabled":true,"settings":{}},"infinite-scroll":{"enabled":true,"settings":{"forumScroll":true,"messageScroll":true,"profileCommentScroll":true,"projectScroll":true,"showFooter":true,"studioScroll":true}},"last-edit-tooltip":{"enabled":true,"settings":{}},"live-featured-project":{"enabled":true,"settings":{"alternativePlayer":"none","autoPlay":false,"forceAlternative":false,"showMenu":false}},"load-extensions":{"enabled":false,"settings":{"music":true,"pen":true,"text2speech":true,"translate":true,"videoSensing":false}},"mediarecorder":{"enabled":true,"settings":{}},"more-links":{"enabled":true,"settings":{}},"mouse-pos":{"enabled":true,"settings":{}},"msg-count-badge":{"enabled":true,"settings":{}},"mute-project":{"enabled":true,"settings":{}},"my-ocular":{"enabled":true,"settings":{"discuss":true,"profile":true}},"onion-skinning":{"enabled":true,"settings":{"afterTint":"#0000FF","beforeTint":"#FF0000","default":true,"layering":"front","mode":"merge","next":0,"opacity":25,"opacityStep":10,"previous":1}},"pause":{"enabled":true,"settings":{}},"progress-bar":{"enabled":true,"settings":{"height":5,"topbar":false}},"project-info":{"enabled":true,"settings":{"editorCount":true}},"project-notes-tabs":{"enabled":true,"settings":{}},"remix-tree-button":{"enabled":true,"settings":{"buttonColor":"#4d97ff"}},"remove-sprite-confirm":{"enabled":true,"settings":{}},"resizable-comment-input":{"enabled":true,"settings":{}},"scratch-messaging":{"enabled":true,"settings":{}},"scratch-notifier":{"enabled":true,"settings":{"becomeownerstudio_notifications":true,"commentsforme_notifications":true,"commentsonmyprojects_notifications":true,"curatorinvite_notifications":true,"favoriteproject_notifications":true,"followuser_notifications":true,"forumpost_notifications":true,"loveproject_notifications":true,"mark_as_read_when_clicked":true,"notification_sound":"addons-ping","remixproject_notifications":true,"studioactivity_notifications":true}},"scratchr2":{"enabled":true,"settings":{"activeColor":"#ff7d7c","linkColor":"#f70000","primaryColor":"#4d97ff"}},"search-load-more-fix":{"enabled":true,"settings":{}},"search-profile":{"enabled":true,"settings":{}},"semicolon":{"enabled":true,"settings":{}},"show-bbcode":{"enabled":true,"settings":{}},"studio-tools":{"enabled":true,"settings":{"mystufftools":true}},"true-youtube-links":{"enabled":true,"settings":{}},"youtube-fullscreen":{"enabled":true,"settings":{}},"longer-wiwo":{"enabled":true,"settings":{}},"variable-manager":{"enabled":true,"settings":{}},"scratchstats":{"enabled":true,"settings":{}},"folders":{"enabled":true,"settings":{}},"block-palette-icons":{"enabled":true,"settings":{}}}}

scratchusernamemrtbts · 2021-03-19T13:34:15Z

yay! merged

This reverts commit 0118d28.

* Bug fixes & code splitting Fix bugs I introduced Split up * style: format code * More changes * style: format code * Unified popup base css! * style: format code * Remove unneeded css * style: format code * Preload light.css * style: format code * Lower fouc * [pull] master from ScratchAddons:master (#203) * New strings from Transifex (#1908) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Better color picker for settings page (#1781) * Init * Removefile * style: format code * Popper, performance, and other changes * style: format code * Fix merge bug * style: format code * Changes * style: format code * Fixes * No_popper * style: format code * Better transparency styling * style: format code * Light and dark modes! * style: format code * Match transparency gradients * Slightly hacky fix for click outside * style: format code * Radius fix * Proper library licensing * style: format code * Remove auto-close for now... * Fixes * style: format code * Fixes * Forked build, non-transparent * style: format code * 5 char change to mimic input[type=color] * Sync thumb thingu * style: format code * Fix * Update on drag * Fix linted changes * style: format code * Non-transparent version * style: format code * Fix self * style: format code * Changes * style: format code * Fixes * Update CREDITS.md * one element * style: format code * Fix W_L's nitpicking Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> * New Addon - 2D Color Picker! (#1768) * add the addon bruh lol * Ran Prettier. Added beta tag * h h * use addon.tab.scratchClass * localization idk if i did this correctly * bruh * aaaaaaaaaaaaaaaaaaaaaaaaaaa * Update 2d-color-picker.json * Update addon.json * Fixed Shift functionality and added real-time color update! * we do a little trolling * scratch class * Better description Co-authored-by: WorldLanguages <mundofinky@gmail.com> * New addon - custom block shape (#1773) * Create addon.json * Update addons.json * Add files via upload * Update addon.json * Rename * Update addon.json * Update userscript.js * Adjustments before PR * Some adjustments * Add corner option and fix notches * Working corner size option * style: format code * Fixed up boolean issues * style: format code * Added notch height option * style: format code * Storing for later * style: format code * Fixed dropdowns and added higher padding cap * Added presets, internal clean-up * style: format code * Changing padding now properly updates workspace * Fix define hat corner issue * style: format code * Flyout partially updates on setting change * style: format code * Fixed C/E block corner issues * style: format code * Flyout now updates correctly * Gave GarboMuffin much-deserved credit * Suggested changes from GarboMuffin * GarboMuffin editor refresh fix and suggested changes from RedGuy12 * Fixed corner path start position * style: format code * Remove beta tag Co-authored-by: lisa-wolfgang <lisa-wolfgang@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> * Add error when scratchdb is down (#1830) * Update userscript.js * style: format code * Update scratchstats.json * Restore userscript.js * Update userscript.js * style: format code Co-authored-by: RedGuy12 <RedGuy12@users.noreply.github.com> * scratchblocks scroll (#1831) * Update addon.json * Create blocks.css * Update blocks.css * Update addon.json * style: format code * Update addon.json * Update addon.json Co-authored-by: RedGuy12 <RedGuy12@users.noreply.github.com> * Make profile page banner less blurry (#1889) * Make profile page banner less blurry * Add blur * Clarify setting name "blur" Co-authored-by: WorldLanguages <mundofinky@gmail.com> * Bump to v1.12.0-prerelease (#1911) * New strings from Transifex (#1913) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Fix some bugs in editor-devtools (#1919) * Fix lint error in 2d-color-picker * editor-devtools: fix capitalization * editor-devtools: do not show send to top in sounds * support cmd key (#1923) * Revert "support cmd key (#1923)" (#1924) This reverts commit 0118d28. * Fix anti-zalgo code (#1912) * New strings from Transifex (#1927) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * New strings from Transifex (#1929) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Drag and drop files into the editor (#1916) * Drag and drop files into the targets pane * Make the costume, sound, and backdrop selector areas also file-droppable * Show blue highlight when dragging a file over a drop area * Fix losing drop area after switching between project and editor page... ...and add l10n: true * Change descriptions, add "recommended" tag Co-authored-by: WorldLanguages <mundofinky@gmail.com> * Fix macos ctrl context menus on mute addon (#1925) * Update userscript.js * style: format code * fix bug Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> Co-authored-by: TheColaber <72760579+TheColaber@users.noreply.github.com> * New strings from Transifex (#1933) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Dango Day Easter Egg (#1931) * init commit * style: format code * why did i do this?? * style: format code * forgot to / 1000 * Settings page: hide by default if not april fools * style: format code * Localize, fix CSS, add close button, remove unnecessary bitwise OR * style: format code * Credit Twemoji * one char bug fix * Update manifest * Avoid "poof" if disabled * Fix typo * Remove fix unrelated to this PR * Better logic on whether to show this addon, fix addon poofing (#1932) * style: format code * Remove unused CSS * Make check for "dango" case insensitive * Make it work in all 4 situations * Only run on profiles (not in /followers etc) Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> * New strings from Transifex (#1946) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Fix #1945 (#1947) * Fix #1945 * Allow uploading entire folders at once * Formatting * Fix verifyBackpack check * New strings from Transifex (#1957) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Use Comlink instead of `template#scratch-addons`, stop spamming contentScriptInfo (#1928) * Use comlink, stop spamming contentScriptInfo * style: format code * Remove debugger; * Fix typo * Add Comlink to libraries * Upload non-linted Comlink (from unpkg) * Add comlink to libraries/CREDITS.md * setMsgCount message: send object instead of integer directly * Remove chrome.tabs.sendMessage debugging trap * Remove window.onmessage debugging event * style: format code * Complete csInfoCache logic * style: format code * Fix todo * Fix todo 2 * Fix todo 3 * Clarify todo 4 * Fix todo 5 Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> * Migrate scratchstats "followers over time" to ScratchDBv3 (#1955) * Migrate scratchstats "followers over time" to ScratchDBv3 * style: format code Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> * Reorder CS logic (#1958) * Fix lint (#1959) * Fix lint * style: format code Co-authored-by: apple502j <apple502j@users.noreply.github.com> * Custom block shape semicolon "fix" (#1960) * Fixed semicolon "glitch" for apple * style: format code Co-authored-by: lisa-wolfgang <lisa-wolfgang@users.noreply.github.com> * v1.12.0 update notification, set new addons (#1964) * v1.12.0 update notification, set new addons, mark old new addons as recommended * Compress gif (-46%) * New strings from Transifex (#1966) Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> * Danger PR checks (#1941) * Create danger.yml * Create dangerfile.js * style: format code * Update dangerfile.js * Update dangerfile.js * style: format code * Update dangerfile.js * Update dangerfile.js * Update dangerfile.js * style: format code * Update danger.yml * Update danger.yml * Update dangerfile.js * style: format code * Update dangerfile.js * style: format code * Update danger.yml * Update dangerfile.js * style: format code * Update danger.yml * Update dangerfile.js * Update dangerfile.js * style: format code * Update dangerfile.js * Fixes * Fix * style: format code * Message * Del/additons * Changes * style: format code * Update dangerfile.js * style: format code * Update dangerfile.js * style: format code * Update danger.yml * Delete package.json * Delete package-lock.json * Update danger.yml * Update dangerfile.js * Update dangerfile.js * style: format code * Update dangerfile.js * style: format code * Update dangerfile.js * style: format code * Update danger.yml * Update danger.yml * Update dangerfile.js * UPGRADE danger * Update danger.yml * Update danger.yml * Rename dangerfile.js to .github/dangerfile.js Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> * Allow setting variable names in Var Manager Addon (#1951) * init * style: format code Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> Co-authored-by: GrahamSH <64214252+GrahamSH-LLK@users.noreply.github.com> Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> Co-authored-by: Ucrash <35695734+GDUcrash@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> Co-authored-by: lisa-wolfgang <43426138+lisa-wolfgang@users.noreply.github.com> Co-authored-by: lisa-wolfgang <lisa-wolfgang@users.noreply.github.com> Co-authored-by: Paul Reid <paul@reid-family.org> Co-authored-by: RedGuy12 <RedGuy12@users.noreply.github.com> Co-authored-by: Maximouse <51849865+mxmou@users.noreply.github.com> Co-authored-by: apple502j <33279053+apple502j@users.noreply.github.com> Co-authored-by: meepooh <66320961+scratchusernamemrtbts@users.noreply.github.com> Co-authored-by: easrng <easrng@gmail.com> Co-authored-by: Sean <ussa.say@gmail.com> Co-authored-by: TheColaber <72760579+TheColaber@users.noreply.github.com> Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> Co-authored-by: GarboMuffin <33787854+GarboMuffin@users.noreply.github.com> Co-authored-by: apple502j <apple502j@users.noreply.github.com> Co-authored-by: GrahamSH <grahamshllk@gmail.com> * Wanna test something * Remove file that is useless with proper css * Compress additional svg * Add xmlns back just in case * Compress svgs even more * Revert "Compress svgs even more" This reverts commit efa42fd. * Move imports for 🌟 speed 🌟 * style: format code * Fix permissions * More general cleanup * Clean up setting inputs * style: format code * Fix media Co-authored-by: GrahamSH-LLK <GrahamSH-LLK@users.noreply.github.com> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: scratchaddons-bot[bot] <73682299+scratchaddons-bot[bot]@users.noreply.github.com> Co-authored-by: Ucrash <35695734+GDUcrash@users.noreply.github.com> Co-authored-by: WorldLanguages <mundofinky@gmail.com> Co-authored-by: lisa-wolfgang <43426138+lisa-wolfgang@users.noreply.github.com> Co-authored-by: lisa-wolfgang <lisa-wolfgang@users.noreply.github.com> Co-authored-by: Paul Reid <paul@reid-family.org> Co-authored-by: RedGuy12 <RedGuy12@users.noreply.github.com> Co-authored-by: Maximouse <51849865+mxmou@users.noreply.github.com> Co-authored-by: apple502j <33279053+apple502j@users.noreply.github.com> Co-authored-by: meepooh <66320961+scratchusernamemrtbts@users.noreply.github.com> Co-authored-by: easrng <easrng@gmail.com> Co-authored-by: Sean <ussa.say@gmail.com> Co-authored-by: TheColaber <72760579+TheColaber@users.noreply.github.com> Co-authored-by: TheColaber <TheColaber@users.noreply.github.com> Co-authored-by: WorldLanguages <WorldLanguages@users.noreply.github.com> Co-authored-by: GarboMuffin <33787854+GarboMuffin@users.noreply.github.com> Co-authored-by: apple502j <apple502j@users.noreply.github.com>

scratchusernamemrtbts added 5 commits February 25, 2021 21:50

Merge pull request #1 from ScratchAddons/master

d18f4e4

Pull commit

Merge pull request #2 from ScratchAddons/master

b3b4748

Pull commit

Merge pull request #3 from ScratchAddons/master

a9e9aac

Pull commit

support cmd key

af31e44

Merge pull request #4 from scratchusernamemrtbts/patch-1

42e9039

support cmd key

scratchusernamemrtbts requested a review from WorldLanguages as a code owner March 19, 2021 13:27

Explosion-Scratch approved these changes Mar 19, 2021

View reviewed changes

TheColaber merged commit 0118d28 into ScratchAddons:master Mar 19, 2021

GrahamSH-LLK added a commit that referenced this pull request Mar 19, 2021

Revert "support cmd key (#1923)"

b4df41c

This reverts commit 0118d28.

GrahamSH-LLK mentioned this pull request Mar 19, 2021

Revert "support Mac command key in mute project player" #1924

Merged

GrahamSH-LLK added a commit that referenced this pull request Mar 19, 2021

Revert "support cmd key (#1923)" (#1924)

d4dac4e

This reverts commit 0118d28.

scratchusernamemrtbts added a commit to scratchusernamemrtbts/ScratchAddons that referenced this pull request Mar 19, 2021

Revert "support cmd key (ScratchAddons#1923)"

516dffe

This reverts commit 0118d28.

Navigation Menu

Uh oh!

support Mac command key in mute project player - #1923

support Mac command key in mute project player#1923
TheColaber merged 5 commits into
ScratchAddons:masterfrom
scratchusernamemrtbts:master

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

Explosion-Scratch commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

cobaltt7 commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

Explosion-Scratch commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

cobaltt7 commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

scratchusernamemrtbts commented Mar 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants