Change Message Count Color - #1914

darn it i wanted to find it so bad lmao

how does it look in light mode?

how does it look in light mode?

still the same

how does it look in light mode?

still the same

no, you dont understand..... how does it look in browser light mode???

what about the scratch color too?

This color is a bit ugly - could you use dark green instead?

snipped
no, you dont understand..... how does it look in browser light mode???

This color is a bit ugly - could you use dark green instead?

I could, should I use a color like the Github comment button?

why did you merge other prs into this one

make a new pr

p.s. maybe a setting on the addon to choose a color?

Note: this green was the same one used by Scratch Messaging Extension

why did you merge other prs into this one

make a new pr

p.s. maybe a setting on the addon to choose a color?

I didn't. I was just keeping this branch up to date with master
p.s. I guess I could? I probally won't tho.

PR is now ok, but why this color exactly?

PR is now ok, but why this color exactly?

Maybe #008000 could be used instead, because it's already used to display the user's own username in comments.

PR is now ok, but why this color exactly?

I can read it.

Maybe #008000 could be used instead, because it's already used to display the user's own username in comments.

That's a good idea.

Feel like this could be a setting... in more settings... Tbh, I don't mind the current green, but I understand if it's hard to read for others.

ps... this branch is from the world-languages org??? lol

Feel like this could be a setting... in more settings... Tbh, I don't mind the current green, but I understand if it's hard to read for others.

ps... this branch is from the world-languages org??? lol

I should do that soon, but I'm in school right now.

ps... yes lol

I just added the option to change the color, can someone test it?

if this is merged, can I be invited to the org?

if this is merged, can I be invited to the org?

See #1183 (comment)

With the current way you are doing this... if we have any more addons that have badges, they would also need that setting... is that how it should be done?

With the current way you are doing this... if we have any more addons that have badges, they would also need that setting... is that how it should be done?

I guess this could be a Scratch Addon wide setting, but no addons other then this one use it so 🤷🏻‍♂️

With the current way you are doing this... if we have any more addons that have badges, they would also need that setting... is that how it should be done?

#10 would need this to be made part of core

I think that this we shouldn't need to bother about moving it to more settings until #10 is implemented.

This is ok as a temporary solution to just having one single addon using the badge. But I see 2 problems with this PR:

1. The default color should be the current, just so current users don't complain and might not find the new setting. Honestly, I can read white on green.
2. You update the color every 2500 milliseconds. Please use a listener so it updates faster.

If we could first implement another addon that may as well want to use the badge, we can flesh out the details like if all addons should have the same badge color, and how should we decide which get prio, etc.

This is ok as a temporary solution to just having one single addon using the badge. But I see 2 problems with this PR:

1. The default color should be the current, just so current users don't complain and might not find the new setting. Honestly, I can read white on green.

I guess, but what is the default hex right now?

2. You update the color every 2500 milliseconds. Please use a listener so it updates faster.

Time to figure out what a listener is, while I'm in class :|

If we could first implement another addon that may as well want to use the badge, we can flesh out the details like if all addons should have the same badge color, and how should we decide which get prio, etc.

I don't want to deal with this until #10 is done

#8ce68c, addon.settings.addEventListener("change", callback)

#8ce68c, addon.settings.addEventListener("change", callback)

Ok, all I need to do is figure out the callback, but I'll do that on my lunch break (1 hour from now)

@TheColaber I added what you asked, could you test it?

The default color should be the current, just so current users don't complain and might not find the new setting. Honestly, I can read white on green.

You can, but not everyone can. Unlike Firefox, Chrome always uses white text on badges, and the current contrast doesn't meet any accessibility guidelines.

The default color should be the current, just so current users don't complain and might not find the new setting. Honestly, I can read white on green.

You can, but not everyone can. Unlike Firefox, Chrome always uses white text on badges, and the current contrast doesn't meet any accessibility guidelines.

Can we just use a darkish blue?

@wgyt I would use green because the badge is already green and most users wouldn't want a completely different color.

Now that we have something that works, can we merge this?

Now that we have something that works, can we merge this?

idk if format code with prettier is required but i think it is

Now that we have something that works, can we merge this?

idk if format code with prettier is required but i think it is

it isn't. It fails ecause it doesn't have access to my fork

Maybe #008000 could be used instead, because it's already used to display the user's own username in comments.

That green is now the default. And users can rollback easily:

Any suggestions for one or two more presets? Some blue shade, maybe? Pure black?

@wgyt Whoops I can't push commits into this PR. Can you check "allow maintainers to idk what" on this PR?

@WorldLanguages Maybe #175ef8 (Recommended tag)?

I think the Forums tag color could be changed to match the new badge color.