Fix "custom Colors addon makes devtools highlighting not work" - #1563
Merged
Conversation
The Blockly method just edited the `fill` attribute, which is overridden by the stylesheet. This way edits the `style` attribute, which overrides everything
WorldLanguages
approved these changes
Feb 12, 2021
Contributor
Author
|
oof srry I forgot to update the title
…________________________________
From: World_Languages <notifications@github.com>
Sent: Friday, February 12, 2021 2:03 PM
To: ScratchAddons/ScratchAddons <ScratchAddons@noreply.github.com>
Cc: Paul Reid <paul@reid-family.org>; Author <author@noreply.github.com>
Subject: Re: [ScratchAddons/ScratchAddons] Fix "custom Colors addon makes devtools highlighting not work" (#1563)
Merged #1563<#1563> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1563 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DEUXLIAYBJFXOJBUGCTS6WCRDANCNFSM4XRE733Q>.
|
griffpatch
added a commit
to griffpatch/ScratchAddons
that referenced
this pull request
Apr 14, 2021
…tom Colors addon makes devtools highlighting not work")
Contributor
|
I've added a fix that was causing previously highlighted blocks to stay highlighted (because only one of the colour changing scripts was addressed in the original fix) |
WorldLanguages
added a commit
that referenced
this pull request
Apr 15, 2021
* Bugfix - Event should have no default background color * Enhancement - Enable / Disable features in settings * Enhancement - Enable / Disable features in settings * Enhancement - Enable / Disable features in settings * Enhancement - Add Make space feature when right click on a block stack * Enhancement - Add Make space feature when right click on a block stack * Enhancement - Add Make space feature when right click on a block stack - Also remove date & version from help * Enhancement - Add Make space feature when right click on a block stack - Also remove date & version from help * Help - Correct Case * Fixup - Remove as yet unused settings, and incorrect usage of undefined keyword * Fix for block flashing bug introduced by #1563 (Fix "custom Colors addon makes devtools highlighting not work") * Enhance manifest wording Co-authored-by: WorldLanguages <mundofinky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1545
Changes
The Blockly method just edited the
fillattribute, which is overridden by the stylesheet. This way edits thestyleattribute, which overrides everything.Reason for changes
it's a bug
Tests
it works