Skip to content

chore: Wrap membership event reasons in parentheses - #1470

Merged
7w1 merged 2 commits into
SableClient:devfrom
Steffo99:colon-membership
Jul 30, 2026
Merged

chore: Wrap membership event reasons in parentheses#1470
7w1 merged 2 commits into
SableClient:devfrom
Steffo99:colon-membership

Conversation

@Steffo99

@Steffo99 Steffo99 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

This PR attempts to slightly improve the visualization of membership join events.

Before

Without the PR, membership events' change reasons are either blended with the rest of the service message text, or not shown entirely in the case of join reasons.

Screenshot before the change.

After

With the PR, all reasons are displayed, and they are wrapped in parentheses.

Screenshot after the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@Steffo99
Steffo99 marked this pull request as ready for review July 29, 2026 21:44
@Steffo99 Steffo99 changed the title Separate with colon membership event reason from notice chore: Wrap membership event reasons in parentheses Jul 29, 2026
@7w1
7w1 added this pull request to the merge queue Jul 30, 2026
Merged via the queue into SableClient:dev with commit 278c278 Jul 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants