Add PMP name colors - #1462
Merged
Merged
Conversation
38 tasks
Contributor
Author
|
Before merging, consider MSC4522! |
charm-cloudhub-social Bot
pushed a commit
to CloudHub-Social/Charm-1.0
that referenced
this pull request
Jul 29, 2026
<!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Replying to a PMP now displays the PMP's name instead of the underlying displayname. <img width="256" height="151" alt="image" src="proxy.php?url=https%3A%2F%2Fgithub.com%2FSableClient%2FSable%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/b82be835-bcfe-4797-9387-783af50dfef2">https://github.com/user-attachments/assets/b82be835-bcfe-4797-9387-783af50dfef2" /> Part of SableClient#1279 #### Considerations - The reply does not indicate that the message author is a PMP. This could be used for impersonation. However, it's unlikely that someone would not notice that the message is not coming from a PMP, given that it is indicated on the actual message. - Currently does not implement SableClient#1462, once one of these two PRs is merged the other will have to add a fix. (Stacked PRs pls :pleading_face:) #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->
Member
|
This PR is now dependent on #1526 in order to have the unstable keys and MUST be merged after it |
nushea
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds name colors to PMPs. This is not using extended profiles, just adding an unstable key onto the Beeper format.
Relevant settings have been added in the Persona submenus, and an option to disable Persona name colors has also been added. (Though this will only disable them in messages, not in a user's own persona settings or persona picker.)
Also (by necessity) makes
NameColorEditormore user-friendly and adds anonChangeoptional callback.Part of #1279
Type of change
Checklist:
AI disclosure: