Skip to content

Add PMP name colors - #1462

Merged
nushea merged 5 commits into
SableClient:devfrom
j0lol:pmp-name-color
Jul 31, 2026
Merged

Add PMP name colors#1462
nushea merged 5 commits into
SableClient:devfrom
j0lol:pmp-name-color

Conversation

@j0lol

@j0lol j0lol commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Adds name colors to PMPs. This is not using extended profiles, just adding an unstable key onto the Beeper format.

"com.beeper.per_message_profile": {
  <snip>
  "eu.she-a.colors": {
    "on_dark": "#ff81e7",
    "on_light": "#da02b2"
  }
},

Relevant settings have been added in the Persona submenus, and an option to disable Persona name colors has also been added. (Though this will only disable them in messages, not in a user's own persona settings or persona picker.)

Also (by necessity) makes NameColorEditor more user-friendly and adds an onChange optional callback.

Part of #1279

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol

j0lol commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Before merging, consider MSC4522!

@j0lol j0lol mentioned this pull request Jul 29, 2026
11 tasks
charm-cloudhub-social Bot pushed a commit to CloudHub-Social/Charm-1.0 that referenced this pull request Jul 29, 2026
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Replying to a PMP now displays the PMP's name instead of the underlying
displayname.
<img width="256" height="151" alt="image"
src="proxy.php?url=https%3A%2F%2Fgithub.com%2FSableClient%2FSable%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/b82be835-bcfe-4797-9387-783af50dfef2">https://github.com/user-attachments/assets/b82be835-bcfe-4797-9387-783af50dfef2"
/>

Part of SableClient#1279

#### Considerations

- The reply does not indicate that the message author is a PMP. This
could be used for impersonation. However, it's unlikely that someone
would not notice that the message is not coming from a PMP, given that
it is indicated on the actual message.
- Currently does not implement SableClient#1462, once one of these two PRs is
merged the other will have to add a fix. (Stacked PRs pls
:pleading_face:)

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
nushea added 3 commits July 31, 2026 08:25
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
@nushea

nushea commented Jul 31, 2026

Copy link
Copy Markdown
Member

This PR is now dependent on #1526 in order to have the unstable keys and MUST be merged after it

@nushea
nushea added this pull request to the merge queue Jul 31, 2026
@nushea
nushea removed this pull request from the merge queue due to a manual request Jul 31, 2026
@nushea
nushea added this pull request to the merge queue Jul 31, 2026
Merged via the queue into SableClient:dev with commit c3831c4 Jul 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants