Change cross-cutting hooks to shared modules and fix menu, thread and sheet regressions - #1367
Conversation
b4ccba5 to
7e5ba5d
Compare
7631ba0 to
bafc945
Compare
bafc945 to
c2d7d00
Compare
880988b to
228494c
Compare
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1367-sable.raspy-dream-bb1d.workers.dev | 228494c | pr-1367 |
Sun, 26 Jul 2026 14:53:54 GMT |
hazre
left a comment
There was a problem hiding this comment.
Massive diff but it seems sane to me just looking at the code, I've yet to test it. My only concern is the Timeline and RoomView stuff and making sure there is no regressions from these changes, I'm not familiar with the code there since @7w1 has changed it a lot since last time I looked at it.
|
Long holding a room on mobile in the RoomView just causes it to flash for a second and nothing happens. Is that a regression? |
Seems like there's something weird going on if you let go too quickly, but I'm only using chromes emulator since holding rooms never worked on iOS anyway. Don't know if its a regression |
Description
Adds a generalized
useMatrixEventhook,useAsyncAction/AsyncButton, a sharedRoomMenu/useRoomMenuActions, and splitsutils/room.tsintounread,relations,hierarchyanddisplaymodules with no barrel. FoldsThreadDrawerontouseTimelineActionsand the shared renderer context, and moves the call feature intofeatures/call/.Also fixes regressions found while reviewing the stack: right-click menus not opening or not anchoring at the cursor, long-press opening the desktop popout instead of the mobile sheet, swipe-to-dismiss shrinking to the drag handle, bottom sheets losing their sheet styling and
role="dialog", thread reactions double-reacting instead of redacting, the thread root being unrepliable, and the DM invite prompt never rendering.Type of change
Checklist:
AI disclosure: