Change menus and overlays to shared responsive primitives - #1358
Merged
Conversation
eleboucher
force-pushed
the
refactor/menu-overlay-primitives
branch
from
July 25, 2026 22:06
46812c1 to
aa20a2f
Compare
7w1
approved these changes
Jul 25, 2026
7w1
force-pushed
the
refactor/menu-overlay-primitives
branch
3 times, most recently
from
July 26, 2026 00:42
852b831 to
b8a3f7b
Compare
7w1
force-pushed
the
refactor/menu-overlay-primitives
branch
from
July 26, 2026 01:18
b8a3f7b to
8a0a0d9
Compare
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1358-sable.raspy-dream-bb1d.workers.dev | 8a0a0d9 | pr-1358 |
Sun, 26 Jul 2026 01:19:47 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds useMenuAnchor and routes anchored menus through ResponsiveMenu, so they hang off their trigger on desktop and rise as a bottom sheet on mobile. Migrates hand-rolled overlays onto ModalOverlay, collapses duplicate select-one menus onto SettingMenuSelector, and deletes the mobileGestures setting. Restores focus trapping in mobile menus and honours the Escape opt-out for verification flows.
Type of change
Checklist:
AI disclosure: