Skip to content

Change menus and overlays to shared responsive primitives - #1358

Merged
7w1 merged 6 commits into
refactor/modal-surfacesfrom
refactor/menu-overlay-primitives
Jul 26, 2026
Merged

Change menus and overlays to shared responsive primitives#1358
7w1 merged 6 commits into
refactor/modal-surfacesfrom
refactor/menu-overlay-primitives

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 25, 2026

Copy link
Copy Markdown
Member

Description

Adds useMenuAnchor and routes anchored menus through ResponsiveMenu, so they hang off their trigger on desktop and rise as a bottom sheet on mobile. Migrates hand-rolled overlays onto ModalOverlay, collapses duplicate select-one menus onto SettingMenuSelector, and deletes the mobileGestures setting. Restores focus trapping in mobile menus and honours the Escape opt-out for verification flows.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 25, 2026 19:45
@7w1 7w1 added the internal label Jul 25, 2026
@eleboucher
eleboucher force-pushed the refactor/menu-overlay-primitives branch from 46812c1 to aa20a2f Compare July 25, 2026 22:06
@7w1
7w1 force-pushed the refactor/menu-overlay-primitives branch 3 times, most recently from 852b831 to b8a3f7b Compare July 26, 2026 00:42
@7w1
7w1 force-pushed the refactor/menu-overlay-primitives branch from b8a3f7b to 8a0a0d9 Compare July 26, 2026 01:18
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1358-sable.raspy-dream-bb1d.workers.dev 8a0a0d9 pr-1358 Sun, 26 Jul 2026 01:19:47 GMT

@7w1
7w1 merged commit c793b58 into refactor/modal-surfaces Jul 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants