Track running action tabs and add Stop action menus - #541
Merged
Conversation
SDSLeon
commented
Aug 9, 2026
Owner
- Add running-state tracking for project action terminals and Stop action menu entries, letting users cancel running dev/build actions from sidebar worktree groups and thread context menus.
- Retain terminal output for finished action tabs so scrollback survives shell exit and survives re-mount, with corrected shell lifecycle teardown tokens.
- Localize the new Stop action labels across all 12 non-English catalogs.
- Add unit coverage for the store, actions, context menus, and terminal layouts.
- Add `runningTabs` state to `devTerminalStore` with `markShellExited` so action/setup shells are marked stopped when their tab closes
- Clear action run tokens and eager-start tokens on shell exit to avoid stale async locks and duplicate re-launches
- Add per-action "Stop {0}" entries to thread, worktree, and project context menus, routed through `stopProjectAction` with worktree-aware paths
- Localize the new Stop strings across all 12 non-English catalogs
- Unsubscribe supervisor/terminal store listeners on unmount in `app.tsx`
- Extend tests for terminal actions, shell completion, context menus, worktree groups, and terminal surfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.