marshal: allow runtime bags to preserve raw code bytes - #8552
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMarshal deserialization hooks
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarshalBag::code_units_from_byteshook for runtime-specific decoding of marshalledco_codemake_code_with_constants_and_byteshook so a runtime can retain the exact public byte stringCodeUnitsbehavior by defaultMotivation
Runtime code objects may accept raw opcode bytes that are not representable by the compiler-core
Instructionenum. CPython and PyPy allow such code objects to round-trip throughmarshal; execution rejects the unknown opcode later. The current shared deserializer rejects these bytes before a runtime bag can preserve them.These defaulted hooks keep compiler-core behavior unchanged while allowing runtimes with a raw-byte fallback to implement that behavior without duplicating the marshal parser.
Validation
cargo fmt --all -- --checkcargo test -p rustpython-compiler-coreThis is a draft while the downstream runtime integration is validated.
Summary by CodeRabbit