extra_tests/snippets/regression_closed_issues.py (1)

27-27: Resolve the Ruff warnings without changing the regression shapes.

The starmap(zip(...)) shape is intentional for #4317, so suppress those exact lint rules inline. The class-level list flags can be plain booleans to avoid RUF012 while preserving destructor behavior. As per coding guidelines, use Ruff for linting Python code.

Proposed Ruff-compatible adjustments

 for _i in range(1000):
-    _b = starmap(_i, zip(_b, _b))
+    _b = starmap(_i, zip(_b, _b))  # noqa: B905, RUF058 - exact `#4317` shape
 assert list(_b) == []

 class _Cls4861:
-    called = [False]
+    called = False
 
     def __del__(self):
-        _Cls4861.called[0] = True
+        _Cls4861.called = True
 
 
 _c = _Cls4861()
 _c = range(10)  # reassignment triggers __del__ on the original instance
 del _c
-assert _Cls4861.called[0]
+assert _Cls4861.called

 class _Dummy4863:
-    fired = [False]
+    fired = False
 
     def __del__(self):
-        if _Dummy4863.fired[0]:
+        if _Dummy4863.fired:
             return
-        _Dummy4863.fired[0] = True
+        _Dummy4863.fired = True
         type(self)()  # this is the exact shape that used to panic
 
 
 _d = _Dummy4863()
 del _d
-assert _Dummy4863.fired[0]
+assert _Dummy4863.fired

Also applies to: 71-81, 91-103

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extra_tests/snippets/regression_closed_issues.py` at line 27, Suppress the
specific Ruff lint warnings inline for the intentional starmap(zip(...)) pattern
around the expression `_b = starmap(_i, zip(_b, _b))` (use per-line noqa
comments for the exact rules raised) so the shape required for the regression
test remains unchanged; also change class-level list "flag" attributes to plain
booleans (replace any top-level empty-list flags with False) to avoid RUF012
while preserving destructor behavior, and apply the same inline noqa and
boolean-flag fixes to the other instances referenced (around lines 71-81 and
91-103) so Ruff passes without altering runtime behavior.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

extra_tests/snippets/regression_closed_issues.py (2)

25-28: Suppress intentional ruff violations with # noqa to keep lint clean.

This section faithfully reproduces the original #4317 report, so the ruff findings (RUF058 starmap-on-zip, B905 missing strict=) are deliberate — the self-referential starmap(_i, zip(_b, _b)) shape is the bug trigger and must not be rewritten to map/strict=True. The same applies to the mutable class attributes on lines 75 and 95 (RUF012), which are used as cross-invocation flags for __del__. Add targeted # noqa codes so CI ruff runs stay green while preserving the regression shape.

As per coding guidelines: "Use ruff for linting Python code".

Proposed suppressions

 _b = []
 for _i in range(1000):
-    _b = starmap(_i, zip(_b, _b))
+    _b = starmap(_i, zip(_b, _b))  # noqa: RUF058, B905 — exact shape from `#4317`
 assert list(_b) == []

 class _Cls4861:
-    called = [False]
+    called = [False]  # noqa: RUF012 — used as a destructor-visible flag

 class _Dummy4863:
-    fired = [False]
+    fired = [False]  # noqa: RUF012 — used as a one-shot __del__ guard

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extra_tests/snippets/regression_closed_issues.py` around lines 25 - 28, The
test intentionally reproduces the ruff issues: add targeted noqa suppressions so
CI stays green while preserving the regression shape — append "# noqa:
RUF058,B905" to the line with the starmap call (the line using starmap(_i,
zip(_b, _b)) where _b and _i are used) and append "# noqa: RUF012" to the two
mutable class attribute declarations used as cross-invocation __del__ flags (the
mutable attributes referenced around the class definitions). Ensure you only add
these specific codes and do not change the starmap/zip pattern or the mutable
attributes themselves.

---

67-84: The regression test correctly exercises the reassignment path. RustPython uses immediate refcount-driven finalization matching CPython: when _c = range(10) reassigns, the previous _Cls4861() instance's refcount drops to 0, triggering PyObjectRef::drop() which synchronously invokes drop_slow_inner() and __del__ before the assignment completes. The assertion at line 84 passes for the correct reason—finalization occurs during reassignment, not deferred to del _c or shutdown.

The proposed assertion tightening is optional but reasonable as defensive documentation:

Optional improvement

 _c = _Cls4861()
 _c = range(10)  # reassignment triggers __del__ on the original instance
+assert _Cls4861.called[0], "__del__ did not run during reassignment"
 del _c
 assert _Cls4861.called[0]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extra_tests/snippets/regression_closed_issues.py` around lines 67 - 84, The
test currently verifies that _Cls4861.__del__ ran by asserting
_Cls4861.called[0] after `del _c`; make this explicit by asserting the flag
immediately after the reassignment to document and lock the intended behavior:
after `_c = range(10)` assert `_Cls4861.called[0]` to show finalization occurred
during reassignment (refer to the class _Cls4861, its __del__ method, and the
variable _c); this is an optional defensive change that clarifies the test's
intent without changing semantics.

extra_tests/snippets/regression_closed_issues.py (1)

74-74: Replace mutable list attributes with plain booleans to resolve Ruff RUF012 violations.

At lines 74 and 94, called = [False] and fired = [False] trigger Ruff's RUF012 warning for mutable class attributes. These list wrappers are unnecessary; the attributes can be plain booleans with the same behavior.

Proposed changes

 class _Cls4861:
-    called = [False]
+    called = False

     def __del__(self):
-        _Cls4861.called[0] = True
+        _Cls4861.called = True

-assert _Cls4861.called[0]
+assert _Cls4861.called

 class _Dummy4863:
-    fired = [False]
+    fired = False

     def __del__(self):
-        if _Dummy4863.fired[0]:
+        if _Dummy4863.fired:
             return
-        _Dummy4863.fired[0] = True
+        _Dummy4863.fired = True
         type(self)()  # this is the exact shape that used to panic

-assert _Dummy4863.fired[0]
+assert _Dummy4863.fired

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@extra_tests/snippets/regression_closed_issues.py` at line 74, Replace the
mutable list attributes used as flags (called = [False] and fired = [False])
with plain booleans (called = False, fired = False) and update all usages that
currently mutate the list (e.g., called[0] = True or if called[0]:) to use
direct boolean assignment and checks (called = True; if called:). Locate the
flags by the identifiers called and fired in the file and modify any test
helpers or closures that relied on the list indirection accordingly so behavior
remains identical while removing the mutable-list wrapper.