Skip to content

Fix test_asyncio for windows #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Feb 2, 2026
Merged

Fix test_asyncio for windows #6959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
830dcf3
fix asyncio
youknowone Feb 2, 2026
13e3527
remove test_asyncio from windows_skip
youknowone Feb 2, 2026
89943fa
Auto-format: cargo fmt --all
github-actions[bot] Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ env:
# test_posixpath: OSError: (22, 'The filename, directory name, or volume label syntax is incorrect. (os error 123)')
# test_venv: couple of failing tests
WINDOWS_SKIPS: >-
test_asyncio
test_glob
test_rlcompleter
test_pathlib
Expand Down
18 changes: 16 additions & 2 deletions crates/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2952,7 +2952,12 @@ impl Compiler {
target: cleanup_end
}
);
self.push_fblock(FBlockType::HandlerCleanup, cleanup_end, cleanup_end)?;
self.push_fblock_full(
FBlockType::HandlerCleanup,
cleanup_end,
cleanup_end,
FBlockDatum::ExceptionName(name.as_ref().unwrap().as_str().to_owned()),
)?;
Some(cleanup_end)
} else {
// no SETUP_CLEANUP for unnamed handler
Expand Down Expand Up @@ -3324,7 +3329,16 @@ impl Compiler {
target: handler_except_block
}
);
self.push_fblock(FBlockType::HandlerCleanup, next_block, end_block)?;
self.push_fblock_full(
FBlockType::HandlerCleanup,
next_block,
end_block,
if let Some(alias) = name {
FBlockDatum::ExceptionName(alias.as_str().to_owned())
} else {
FBlockDatum::None
},
)?;

// Execute handler body
self.compile_statements(body)?;
Expand Down
Loading