Update codecs and test_codecs from cpython v3.12.4#5372
Merged
youknowone merged 8 commits intoRustPython:mainfrom Jul 29, 2024
Koimeijisan:codecs
Merged
Update codecs and test_codecs from cpython v3.12.4#5372youknowone merged 8 commits intoRustPython:mainfrom Koimeijisan:codecs
youknowone merged 8 commits intoRustPython:mainfrom
Koimeijisan:codecs
Conversation
youknowone
reviewed
Jul 29, 2024
Author
|
I marked all the tests that were windows related with the line specified, thank you for helping me out. |
youknowone
requested changes
Jul 29, 2024
Member
youknowone
left a comment
There was a problem hiding this comment.
Thank you for contributing! I am surprised that this is pretty well-formed patch. I couldn't believe it was your first patch.
youknowone
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to open source. If there is anything that needs changed, please let me know.