oh, test_dataclasses seems to be related the message changes too

oh, test_dataclasses seems to be related the message changes too

The test_dataclasses is now a test folder instead of a single test file, and in what way should it be updated?

We have 2 choices.

1. Update test_dataclasses first and finish this PR later. The existing single file will be replaced by folder with this patch.
2. Mark @unittest.expectedFalure to current dataclasses test. Then they will be fixed when we update the test later.

We have 2 choices.

1. Update test_dataclasses first and finish this PR later. The existing single file will be replaced by folder with this patch.
2. Mark @unittest.expectedFalure to current dataclasses test. Then they will be fixed when we update the test later.

The test files in the folder seems to be unrelated with the test_dataclasses.py though

I checked cpython repository. test_dataclasses.py looks still a file in Python 3.12. https://github.com/python/cpython/blob/v3.12.0/Lib/test/test_dataclasses.py
Could you share what's the folder?

I checked cpython repository. test_dataclasses.py looks still a file in Python 3.12. https://github.com/python/cpython/blob/v3.12.0/Lib/test/test_dataclasses.py Could you share what's the folder?

Oh I was checking out the 3.12 branch, why is my url not working :(
My bad, I will keep up with the main branch
https://github.com/python/cpython/tree/3.12/Lib/test/test_dataclasses

Got it. I think the test is moved to https://github.com/python/cpython/blob/3.12/Lib/test/test_dataclasses/__init__.py

If you run test through -m test, both file and folder will work in same way.
cargo run -- -m test test_dataclasses

Got it. I think the test is moved to https://github.com/python/cpython/blob/3.12/Lib/test/test_dataclasses/__init__.py

If you run test through -m test, both file and folder will work in same way. cargo run -- -m test test_dataclasses

Oh, but we are still following the main branch right? Then I will update the test file and ignore the folder
Well both test_dataclasses.py from rustpython and cpython are the same

I prefer to follow recent distribution's tag. I'd like recommend v3.12.1 tag at this time. https://github.com/python/cpython/tree/v3.12.1

I prefer to follow recent distribution's tag. I'd like recommend v3.12.1 tag at this time. https://github.com/python/cpython/tree/v3.12.1

I found that test_dataclasses needs support from dataclasses.py, which the latter would went into the match statement support issue

Marking test_dataclasses expectedFailure seems reasonable in that case.

Marking test_dataclasses expectedFailure seems reasonable in that case.

No it's not working. Things get worse when comment out the parts cuz it is not in a test function

Marking test_dataclasses expectedFailure seems reasonable in that case.

I made this temporary change here: https://github.com/RustPython/RustPython/pull/5140/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7R3679