Skip to content

Conversation

@AvivDavid23
Copy link
Contributor

@AvivDavid23 AvivDavid23 commented Jan 27, 2026

Reverts #1487


Note

Reverts prior depth-limiting behavior and simplifies path/update handling.

  • Removes MAX_DEPTH and calculate_value_depth from json_path/select_value; drops all recursion-depth checks across set_value, merge_value, arr_append/insert, etc., and refactors path traversal to not track depth
  • Makes error helpers crate-private and deletes err_recursion_limit_exceeded
  • RDB loader now deserializes with recursion limit disabled; tests updated to allow exceeding overall nesting via updates and to verify unbounded-depth RDB restore, while still erroring on overly deep single-value roots

Written by Cursor Bugbot for commit f74657d. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.55%. Comparing base (85bb358) to head (f74657d).

Files with missing lines Patch % Lines
redis_json/src/ivalue_manager.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   77.82%   77.55%   -0.28%     
==========================================
  Files          15       15              
  Lines        3897     3832      -65     
==========================================
- Hits         3033     2972      -61     
+ Misses        864      860       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants