Skip to content

MOD-9365 Add panic handler, log panic message (#1427)#1430

Merged
AvivDavid23 merged 1 commit into8.4from
8.4_aviv
Oct 23, 2025
Merged

MOD-9365 Add panic handler, log panic message (#1427)#1430
AvivDavid23 merged 1 commit into8.4from
8.4_aviv

Conversation

@AvivDavid23
Copy link
Copy Markdown
Contributor

@AvivDavid23 AvivDavid23 commented Oct 23, 2025

(cherry picked from commit c8fee2a)


Note

Add a panic hook that logs payload and location to Redis warnings and initialize it during module startup.

  • Module initialization (redis_json/src/lib.rs):
    • Add setup_panic_handler() and invoke it at startup in initialize().
    • Panic hook logs warning with panic payload and location, then defers to default hook.
    • No other functional changes to commands or types.

Written by Cursor Bugbot for commit 898a44c. This will update automatically on new commits. Configure here.

@AvivDavid23 AvivDavid23 requested a review from gabsow October 23, 2025 08:16
@cursor
Copy link
Copy Markdown

cursor bot commented Oct 23, 2025

Bug: Panic Handler Log Formatting Issue

The setup_panic_handler formats panic messages inconsistently when location information is unavailable. The fallback string "UNKNOWN PANIC LOCATION" lacks a leading space, causing it to concatenate directly with the panic payload. This results in malformed log messages, unlike the properly spaced format used when location details are present.

Fix in Cursor Fix in Web

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.74%. Comparing base (b524a91) to head (898a44c).
⚠️ Report is 6 commits behind head on 8.4.

Files with missing lines Patch % Lines
redis_json/src/lib.rs 20.83% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #1430      +/-   ##
==========================================
- Coverage   79.28%   77.74%   -1.54%     
==========================================
  Files          15       16       +1     
  Lines        3707     3932     +225     
==========================================
+ Hits         2939     3057     +118     
- Misses        768      875     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AvivDavid23 AvivDavid23 merged commit 6cfe3fc into 8.4 Oct 23, 2025
19 of 21 checks passed
@AvivDavid23 AvivDavid23 deleted the 8.4_aviv branch October 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants