Added TCK tests for Subscriber and Processor.#8
Merged
ldaley merged 1 commit intoReactiveX:0.xfrom Oct 29, 2014
emanuelpalm:0.x
Merged
Added TCK tests for Subscriber and Processor.#8ldaley merged 1 commit intoReactiveX:0.xfrom emanuelpalm:0.x
ldaley merged 1 commit intoReactiveX:0.xfrom
emanuelpalm:0.x
Conversation
Collaborator
|
Hi @emanuelpalm Just wanted to let you know I have looking at this on my todo list. I'll get to it in the next day or so and provide what feedback I can. |
Contributor
Author
|
@alkemist Very much appreciated. Thank you! |
Collaborator
|
Going to merge, and then take a look. |
ldaley
added a commit
that referenced
this pull request
Oct 29, 2014
Added TCK tests for Subscriber and Processor.
Contributor
Author
|
@alkemist Alright. Thanks! |
Collaborator
|
@emanuelpalm I did some more work on this, and got things a bit greener. Some of the processor tests are still not passing. There are failing tests for the whitebox subscriber tests too that I've commented out because I think they're invalid tests. Apologies for making the changes rather than giving you feedback, but the only way I was able to work out what to do was to experiment. |
Contributor
Author
|
@alkemist No problem! I'm glad my contribution made some difference at all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've hooked Subscriber into SubscriberBlackboxVerification and SubscriberWhiteboxVerification. I also attempted at creating a SubjectProcessor class which wraps a Subject and uses it as a Processor, but I keep getting wierd test results.
Lastly, I haven't yet figured out a good way to actually test the concrete onSubscribe handler, which can be seen here.
If this seems like a good start, then go ahead and merge on. Either way I would gladly accept some thoughts or guidelines I could continue to work with.
By the way, current rest results are as follows:
152 tests completed, 22 failed, 59 skipped