Add docs and move to 0.4.0.M2#6
Merged
benjchristensen merged 2 commits intoReactiveX:0.xfrom Oct 7, 2014
Merged
Conversation
This changeset updates the dependency to the latest milestone release and changes to code to fix the issues described pre M2. Especially - backpressure now uses a long instead of an int - contravariance is used for the reactive streams subscriber
Member
|
Thanks! |
Collaborator
Author
|
Oh dear, I just noticed that #3 is also open. I just kept fixing while adding the docs ;) Go ahead and merge whatever you want hehe |
benjchristensen
added a commit
that referenced
this pull request
Oct 7, 2014
Add docs and move to 0.4.0.M2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There we go, this adds javadocs to the classes and also updates to M2, fixing the described issues (backpressure long/int and contravariance on the subscriber)
ping @benjchristensen and @alkemist