Use styler base_indention#404
Merged
renkun-ken merged 4 commits intoREditorSupport:masterfrom Apr 3, 2021
Merged
Conversation
Member
|
Perhaps we could specify the following item that see https://cran.r-project.org/web/packages/devtools/vignettes/dependencies.html for details |
Member
Author
|
Do we also include this PR in the upcoming release? The macOS and Windows builds of styler are not ready due to the binary builds are still on the way. |
Member
|
Let's wait for the binaries for styler then. |
Member
Author
|
The binary builds on all platforms are ready and the CI passes now. |
Member
Author
|
@randy3k Looks like we could do a new release then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400.
This PR uses the latest styler
base_indentionand removes the old hacking way to add indention.I think we could wait until r-lib/styler#764 is merged upstream so that this PR could be merged too.
We'll update the minimum version of styler in
DESCRIPTIONif a new version (probably v1.4.1) is released to CRAN.