test json - mariadb without JSON type #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 86.24% 86.28% +0.04%
==========================================
Files 17 17
Lines 2436 2436
Branches 258 258
==========================================
+ Hits 2101 2102 +1
Misses 249 249
+ Partials 86 85 -1 ☔ View full report in Codecov by Sentry. |
MariaDB-11.0.1 removed the 5.5.5 version hack (MDEV-28910). MariaDB still doesn't support JSON as a type. Use get_mysql_vendor() == mysql for the final part of test_json.
f4271ff to
1f42a2b
Compare
Member
|
thanks |
Nothing4You
added a commit
to Nothing4You/aiomysql
that referenced
this pull request
Sep 21, 2025
MariaDB 11.0.1 removed the 5.5.5 version hack that used to skip this test for MariaDB. Port of PyMySQL/PyMySQL@b4ed688 from PyMySQL/PyMySQL#1165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MariaDB-11.0.1 removed the 5.5.5 version hack (MDEV-28910).
MariaDB still doesn't support JSON as a type.
Use get_mysql_vendor() == mysql for the final part of test_json.
As tested: https://buildbot.mariadb.org/#/builders/158/builds/7720/steps/4/logs/stdio