Skip to content

WIP: Update template to use PSL 5.1.0#66

Merged
JamesWTruher merged 2 commits intoPowerShell:masterfrom
rkeithhill:update-to-5.1.0-final
Sep 25, 2019
Merged

WIP: Update template to use PSL 5.1.0#66
JamesWTruher merged 2 commits intoPowerShell:masterfrom
rkeithhill:update-to-5.1.0-final

Conversation

@rkeithhill
Copy link
Copy Markdown
Contributor

@rkeithhill rkeithhill commented Aug 10, 2019

There are a few things that need to be worked out here. There was a PR merged by @JamesWTruher back in March that updated parts of the template for use of PSL 5.1.1. But I don't see a 5.1.1 version on nuget.org. The latest there is 5.1.0.

Also, I installed the template today and the project it scaffolded for me was still using 5.1.0-preview-06. So I think we need an update to move to 5.1.0 or perhaps 5.1.1 when it gets published to nuget.org.

I updated the generated module manifest copyright to 2019 and added code-block language specifiers in the README.md file to eliminate the markdownlint warnings I was getting.

rkeithhill
rkeithhill commented Aug 10, 2019
View reviewed changes
Comment thread ...Module.Template/Microsoft.PowerShell.Standard.Module.Template/.template.config/template.json
}
],
"replaces": "5.1.0-preview-06"
"replaces": "5.1.0"
Copy link
Copy Markdown
Contributor Author

@rkeithhill rkeithhill Aug 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this does exactly but figured it had to be changed to remove the -preview-06 ref.

Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the right call - basically, it will replace instances of what's in replaces with the choice based on what flags are used when dotnet new is called.

@rkeithhill
Copy link
Copy Markdown
Contributor Author

rkeithhill commented Aug 10, 2019

Also, the README.md refers to 5.1.1:

Options:
  -v|--powershell-standard-version
                                        5.1.1               - PowerShell Standard 5.1.1

So if this PR were to go through using 5.1.0, I'll need to update the README to refer to 5.1.0.

@TylerLeonhardt
Copy link
Copy Markdown
Member

TylerLeonhardt commented Aug 14, 2019

AFAIK, a 5.1.1 isn't happening any time soon so lets go with 5.1.0. Can you update the README to refer to 5.1.0?

@rkeithhill
Copy link
Copy Markdown
Contributor Author

rkeithhill commented Aug 14, 2019

Sure, I'll do that tonight.

TylerLeonhardt
TylerLeonhardt reviewed Aug 16, 2019
View reviewed changes
Comment thread tools/releaseBuild/signing.xml
<file src="__INPATHROOT__\release\out\PowerShellStandard.Library.5.1.1.nupkg" signType="CP-401405"
dest="__OUTPATHROOT__\release\out\PowerShellStandard.Library.5.1.1.nupkg" />
<file src="__INPATHROOT__\release\out\PowerShellStandard.Library.5.1.0.nupkg" signType="CP-401405"
dest="__OUTPATHROOT__\release\out\PowerShellStandard.Library.5.1.0.nupkg" />
Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher can you speak to this change? Why does the signing.xml have 5.1.1?

Copy link
Copy Markdown
Contributor Author

@rkeithhill rkeithhill Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher @TylerLeonhardt Any chance of getting this PR moved through? It would be nice if the template folks installed with dotnet worked better. :-)

Copy link
Copy Markdown
Contributor

@JamesWTruher JamesWTruher Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah - sorry, I thought I had pushed 5.1.1 months ago. I'll make this happen

@JamesWTruher
Copy link
Copy Markdown
Contributor

JamesWTruher commented Sep 25, 2019

The changes found in b69d5e6 added a net452 assembly, along with a number of other additions, but somehow was unreleased. I'll take this PR, but produce another PR to push the version everywhere to 5.1.1. I'm uncomfortable with doing another release without updating the release number

@JamesWTruher JamesWTruher merged commit 6c56952 into PowerShell:master Sep 25, 2019
@rkeithhill
Copy link
Copy Markdown
Contributor Author

rkeithhill commented Sep 25, 2019

Works for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

@JamesWTruher JamesWTruher JamesWTruher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TylerLeonhardt TylerLeonhardt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkeithhill @TylerLeonhardt @JamesWTruher