Add document symbols for #region - #2003
Merged
Merged
Conversation
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/region-symbols
branch
from
February 24, 2023 21:45
1fbd190 to
d7d1d30
Compare
Patrick Meinecke (SeeminglyScience)
requested changes
Feb 28, 2023
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
Lookin' good, just one thing we need to change up
|
|
||
| /// <summary> | ||
| /// Format a script given its contents. | ||
| /// TODO: This needs to be cancellable. |
Member
Author
There was a problem hiding this comment.
This one is a big ol' "waiting on PSSA" right?
Co-authored-by: Andy Jordan <andy.jordan@microsoft.com>
Removing the timer and unnecessary allocations.
By consistently using a static empty container, and breaking instead of throwing on cancellation.
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/region-symbols
branch
from
February 28, 2023 21:57
d7d1d30 to
e16ca88
Compare
Patrick Meinecke (SeeminglyScience)
approved these changes
Feb 28, 2023
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some technical debt clean-ups.
Replaces (and re-uses!) Frode Flaten (@fflaten)'s #1911.
Resolves PowerShell/vscode-powershell#3604 and PowerShell/vscode-powershell#3210.